Skip to content

Comments

fix: fix userlib#346

Merged
hansl merged 5 commits intomasterfrom
eftychis-rollback-dfinity
Jan 30, 2020
Merged

fix: fix userlib#346
hansl merged 5 commits intomasterfrom
eftychis-rollback-dfinity

Conversation

@eftychis
Copy link
Contributor

No description provided.

Remove endianness fix
@eftychis eftychis force-pushed the eftychis-rollback-dfinity branch from 105e058 to 7d2ea66 Compare January 29, 2020 20:16
@eftychis
Copy link
Contributor Author

Trying to test locally -- have nix version issue.

@eftychis eftychis marked this pull request as ready for review January 29, 2020 20:32
@eftychis eftychis requested a review from a team as a code owner January 29, 2020 20:32
@nomeata
Copy link
Contributor

nomeata commented Jan 29, 2020

Am I missing some context? Is this still not a blob with the version of the replica this is targeting?

@eftychis
Copy link
Contributor Author

works for me right now.

@eftychis eftychis force-pushed the eftychis-rollback-dfinity branch from 4d6d79a to c076530 Compare January 30, 2020 00:22
@hansl hansl merged commit 38597bb into master Jan 30, 2020
@hansl hansl deleted the eftychis-rollback-dfinity branch January 30, 2020 00:43
@eftychis
Copy link
Contributor Author

@hansl Should we add this functionality in simple-cbor? Right now it treats u64 in a special way for hexadecimal strings but does not offer other options.

@hansl
Copy link
Contributor

hansl commented Jan 30, 2020

What functionality specifically?

@eftychis eftychis mentioned this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants