Skip to content

Comments

feat: Accept flags in more positions#2521

Merged
mergify[bot] merged 12 commits intomasterfrom
spofford/global-args
Aug 31, 2022
Merged

feat: Accept flags in more positions#2521
mergify[bot] merged 12 commits intomasterfrom
spofford/global-args

Conversation

@adamspofford-dfinity
Copy link
Contributor

#2369 moved flags to a more traditional location, but in doing so broke scripts, as well as making the code worse. This enables both behaviors with code closer to the original.

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review August 31, 2022 18:59
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner August 31, 2022 18:59
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog section added previously

@mergify mergify bot merged commit a25898f into master Aug 31, 2022
@mergify mergify bot deleted the spofford/global-args branch August 31, 2022 22:25
@ghost ghost mentioned this pull request Aug 31, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant