feat: move all the args to the end#2369
Merged
adamspofford-dfinity merged 15 commits intomasterfrom Aug 4, 2022
Merged
Conversation
wonder if our regexes should start ending in $
ghost
approved these changes
Jul 25, 2022
ghost
reviewed
Aug 1, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
#2369 moved flags to a more traditional location, but in doing so broke scripts, as well as making the code worse. This enables both behaviors with code closer to the original.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard format of commands is
cmd subcmd1 subcmd2 --namedflag1 --namedflag2. Indfx, it is insteadcmd --namedflag1 subcmd1 --namedflag2 subcmd2. This is a source of confusion for new users and experienced users alike. This PR moves all the flags to the end of the command; the new valid syntax isdfx canister create --all --identity alice --network ic --wallet "$WALLET".Implements SDK-604.
Fixes #835.