Closed
Conversation
cfb8b8f to
7957415
Compare
|
Closing because #2521 has made the changes in a backwards-compatible way. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The location of some flags has moved. For example:
This is quite disruptive, as it breaks almost every script that uses dfx.
This PR implements backwards-compatibility by accepting the old format in a few common cases. It does not attempt to cover all possible situations where we know how to rewrite from the old syntax to the new. It removes 90% of the pain with 10% of the code.
Alternatives considered
Update all the code. This would however break any case where say
snswas used with an older version of dfx. Also, updating to this latest dfx would break our CI in many places and I doubt we could fix it all at once.How Has This Been Tested?
I have used this for an SNS deployment, as that uses quite a few scripts in our inventory, as well as the sns binary which has calls to dfx baked into the code.
If this general approach seems OK I am happy to write bash tests as well.
Checklist: