feat!: Move the args to the end#126
Merged
adamspofford-dfinity merged 7 commits intomasterfrom Aug 4, 2022
Merged
Conversation
viviveevee
requested changes
Aug 3, 2022
Contributor
viviveevee
left a comment
viviveevee
left a comment
There was a problem hiding this comment.
Can you also add a changelog entry for this, please?
viviveevee
approved these changes
Aug 4, 2022
Merged
adamspofford-dfinity
added a commit
that referenced
this pull request
Aug 29, 2022
A bug was introduced with `quill generate` in #126 around the repetition of a `clap` argument. Because the `pem_file` and `seed_file` parameters were repeated twice in the same command, running the command would crash. This fixes it by removing the common flags from the command, as they are not used at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dfinity/sdk#2369.