Skip to content

Bump motoko#182

Merged
mergify[bot] merged 1 commit intomasterfrom
joachim/bump-motoko
Nov 20, 2019
Merged

Bump motoko#182
mergify[bot] merged 1 commit intomasterfrom
joachim/bump-motoko

Conversation

@nomeata
Copy link
Contributor

@nomeata nomeata commented Nov 19, 2019

and drop the patching of motoko derivations in the SDK’s overlay, by
pulling in
caffeinelabs/motoko#887 (comment).

~/dfinity/motoko $ git log 8676951c41fbf9b9c87c1c4de606d4dfd321a829..6901c536deff066671aa96c6e765d96a7415bb40 --oneline --first-parent
6901c536 (HEAD -> master, origin/master, origin/HEAD) default.nix: Remove packaging code (#887)
b5a74f08 Fix for #874 (#877)
ce3a3107 Merge pull request #841 from dfinity-lab/joachim/ic-stub
cbe634ed Claudio/oneway awaits (#773)
14793c25 IDL-Motoko: Pass actor and func references as data (#883)
abf22153 Update IDL func type (#881)

and drop the patching of motoko derivations in the SDK’s overlay, by
pulling in
caffeinelabs/motoko#887 (comment).

```
~/dfinity/motoko $ git log 8676951c41fbf9b9c87c1c4de606d4dfd321a829..6901c536deff066671aa96c6e765d96a7415bb40 --oneline --first-parent
6901c536 (HEAD -> master, origin/master, origin/HEAD) default.nix: Remove packaging code (#887)
b5a74f08 Fix for #874 (#877)
ce3a3107 Merge pull request #841 from dfinity-lab/joachim/ic-stub
cbe634ed Claudio/oneway awaits (#773)
14793c25 IDL-Motoko: Pass actor and func references as data (#883)
abf22153 Update IDL func type (#881)
```
@nomeata nomeata requested a review from a team as a code owner November 19, 2019 22:30
@nomeata
Copy link
Contributor Author

nomeata commented Nov 19, 2019

This pulls in caffeinelabs/motoko#881, so maybe too early. @chenyan-dfinity will know

@chenyan-dfinity
Copy link
Contributor

This pulls in dfinity-lab/motoko#881, so maybe too early. @chenyan-dfinity will know

It should be fine, we don't have JS userlib in master, and the change is in favor of the new userlib.
But we are getting that strange e2e client failure again...

@nomeata
Copy link
Contributor Author

nomeata commented Nov 19, 2019

A restart of the build helped. The test seems to be inherently flaky :-(

installPhase = ''
mkdir -p $out
cp ${src}/stdlib/*.mo $out
rm $out/*Test.mo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does motoko do this now instead? If not I think this will break things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulyoung
Copy link
Contributor

The test seems to be inherently flaky :-(

This seems to be a recent development despite the test not changing

@mergify mergify bot merged commit b38a7e6 into master Nov 20, 2019
@mergify mergify bot deleted the joachim/bump-motoko branch November 20, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants