Skip to content

fix: Use rustls and webpki-roots to avoid certification validation error#773

Merged
mergify[bot] merged 2 commits intomasterfrom
paulliu/webpki
Jul 7, 2020
Merged

fix: Use rustls and webpki-roots to avoid certification validation error#773
mergify[bot] merged 2 commits intomasterfrom
paulliu/webpki

Conversation

@ninegua
Copy link
Member

@ninegua ninegua commented Jul 3, 2020

It solves the linux/NixOS problem of "unable to get local issuer certification", but needs to be tested on mac too.

Closes #516
Closes #687
Closes #550

@ninegua ninegua requested a review from a team as a code owner July 3, 2020 19:25
@ninegua ninegua requested a review from hansl July 3, 2020 19:25
@ninegua ninegua changed the title Use rustls and webpki-roots to avoid certification validation error fix: Use rustls and webpki-roots to avoid certification validation error Jul 3, 2020
@ninegua
Copy link
Member Author

ninegua commented Jul 6, 2020

Apparently it was not just a NixOS thing, our users reported the bug on Arch Linux and Ubuntu too https://forum.dfinity.org/t/bug-dfx-start-upgrade-fail-on-arch-linux/545

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Mac too.
image

@alexabsmith
Copy link
Contributor

FYI @ninegua @hansl this bug from the forum was being tracked here: #516

Should I close this issue, too?

@hansl
Copy link
Contributor

hansl commented Jul 7, 2020

@alexabsmith updated the description to properly close issues.

@mergify mergify bot merged commit 759c76e into master Jul 7, 2020
@mergify mergify bot deleted the paulliu/webpki branch July 7, 2020 03:39
@mergify mergify bot removed the automerge-squash label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dfx upgrade bug with certain Linux distros dfx upgrade bug with 0.5.4 dfx start/upgrade fail on Arch Linux

3 participants