default.nix: Remove packaging code#887
Merged
mergify[bot] merged 2 commits intomasterfrom Nov 19, 2019
Merged
Conversation
Judging from how the SDK imports Motoko, all this stuff is not actually used, so remove it. Also, they override the `buildPhase` of `stdlib` in https://github.com/dfinity-lab/sdk/blob/master/nix/overlays/motoko.nix let’s just do this properly here.
hansl
reviewed
Nov 19, 2019
| forceShare = ["man"]; | ||
| }; | ||
|
|
||
| stdlib-doc-live = stdenv.mkDerivation { |
There was a problem hiding this comment.
The documentation might still be useful. Don’t you publish Motoko doc from this repo?
Contributor
Author
There was a problem hiding this comment.
Yes, stdlib-doc. Essentially stdlib-doc-live becomes stdlib-doc (as it was some months ago)
nomeata
added a commit
to dfinity/sdk
that referenced
this pull request
Nov 19, 2019
and drop the patching of motoko derivations in the SDK’s overlay, by pulling in caffeinelabs/motoko#887 (comment). ``` ~/dfinity/motoko $ git log 8676951c41fbf9b9c87c1c4de606d4dfd321a829..6901c536deff066671aa96c6e765d96a7415bb40 --oneline --first-parent 6901c536 (HEAD -> master, origin/master, origin/HEAD) default.nix: Remove packaging code (#887) b5a74f08 Fix for #874 (#877) ce3a3107 Merge pull request #841 from dfinity-lab/joachim/ic-stub cbe634ed Claudio/oneway awaits (#773) 14793c25 IDL-Motoko: Pass actor and func references as data (#883) abf22153 Update IDL func type (#881) ```
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Judging from how the SDK imports Motoko, all this stuff is not actually
used, so remove it.
Also, they override the
buildPhaseofstdlibinhttps://github.com/dfinity-lab/sdk/blob/master/nix/overlays/motoko.nix
let’s just do this properly here.