test: fix assertion that replica has stopped running#1240
Closed
test: fix assertion that replica has stopped running#1240
Conversation
p-shahi
approved these changes
Dec 8, 2020
ghost
reviewed
Dec 8, 2020
e2e/bats/utils/assertions.bash
Outdated
| assert_no_dfx_start_or_replica_processes() { | ||
| ! ( ps | grep "[/[:space:]]dfx start" ) | ||
| ! ( ps | cat .dfx/replica-configuration/replica-pid ) | ||
| ! ( ps | grep "$(cat .dfx/replica-configuration/replica-pid)" ) |
There was a problem hiding this comment.
this grep looks for the pid anywhere, so if replica-pid contains 337 and there is a pid 1337 it will think everything is all good
ghost
reviewed
Dec 8, 2020
e2e/bats/utils/assertions.bash
Outdated
| assert_no_dfx_start_or_replica_processes() { | ||
| ! ( ps | grep "[/[:space:]]dfx start" ) | ||
| ! ( ps | cat .dfx/replica-configuration/replica-pid ) | ||
| .dfx/replica-configuration/replica-pid && (! ( ps | grep "$(cat .dfx/replica-configuration/replica-pid)" )) |
There was a problem hiding this comment.
this grep looks for the pid anywhere, so if replica-pid contains 337 and there is a pid 1337 it will think everything is all good
Contributor
Author
There was a problem hiding this comment.
Yeah you're right. I'm still exploring this.
p-shahi
suggested changes
Dec 8, 2020
Contributor
p-shahi
left a comment
p-shahi
left a comment
There was a problem hiding this comment.
changing approve back to req changes until this is fixed
Contributor
|
addressed by #1338 therefore closing |
dfinity-bot
added a commit
that referenced
this pull request
May 12, 2022
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@eb8c788b...ca1383b2](rustsec/advisory-db@eb8c788...ca1383b) * [`30e1ac3c`](rustsec/advisory-db@30e1ac3) Create RUSTSEC-0000-0000.md ([RustSec/advisory-db#1236](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1236)) * [`7b009b96`](rustsec/advisory-db@7b009b9) Assigned RUSTSEC-2022-0023 to static_type_map ([RustSec/advisory-db#1238](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1238)) * [`0653c8f3`](rustsec/advisory-db@0653c8f) Self-report double-checked-cell as unmaintained ([RustSec/advisory-db#1239](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1239)) * [`ba96a137`](rustsec/advisory-db@ba96a13) Assigned RUSTSEC-2022-0024 to double-checked-cell ([RustSec/advisory-db#1240](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1240)) * [`ca1383b2`](rustsec/advisory-db@ca1383b) Withdraw RUSTSEC-2020-0159: unsound `localtime_r` call in `chrono` ([RustSec/advisory-db#1241](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1241))
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2022
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@eb8c788b...ca1383b2](rustsec/advisory-db@eb8c788...ca1383b) * [`30e1ac3c`](rustsec/advisory-db@30e1ac3) Create RUSTSEC-0000-0000.md ([RustSec/advisory-db#1236](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1236)) * [`7b009b96`](rustsec/advisory-db@7b009b9) Assigned RUSTSEC-2022-0023 to static_type_map ([RustSec/advisory-db#1238](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1238)) * [`0653c8f3`](rustsec/advisory-db@0653c8f) Self-report double-checked-cell as unmaintained ([RustSec/advisory-db#1239](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1239)) * [`ba96a137`](rustsec/advisory-db@ba96a13) Assigned RUSTSEC-2022-0024 to double-checked-cell ([RustSec/advisory-db#1240](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1240)) * [`ca1383b2`](rustsec/advisory-db@ca1383b) Withdraw RUSTSEC-2020-0159: unsound `localtime_r` call in `chrono` ([RustSec/advisory-db#1241](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1241))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.