Skip to content

test: fix assertion that replica has stopped running #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hansl wants to merge 10 commits into from
Closed

test: fix assertion that replica has stopped running #1240

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
114507e
test: fix assertion that replica has stopped running
hansl Dec 8, 2020
e42dee7
.
hansl Dec 8, 2020
325d97e
.
hansl Dec 8, 2020
3790025
.
hansl Dec 8, 2020
6729e25
.
hansl Dec 8, 2020
a6dd455
.
hansl Dec 8, 2020
46f76b0
.
hansl Dec 8, 2020
fbba484
.
hansl Dec 8, 2020
1becafd
.
hansl Dec 8, 2020
6981de8
Merge branch 'master' into hansl/fix-assertions
p-shahi Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/bats/utils/assertions.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!
#!/usr/bin/env bash

# Asserts that a command line succeeds. Still sets $output to the stdout and stderr
# of the command.
Expand Down Expand Up @@ -149,7 +149,7 @@ assert_process_exits() {
# Asserts that `dfx start` and `replica` are no longer running
assert_no_dfx_start_or_replica_processes() {
! ( ps | grep "[/[:space:]]dfx start" )
! ( ps | cat .dfx/replica-configuration/replica-pid )
! ( ps | grep "$(cat .dfx/replica-configuration/replica-pid)" )

@ghost ghost Dec 8, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this grep looks for the pid anywhere, so if replica-pid contains 337 and there is a pid 1337 it will think everything is all good

}

assert_file_eventually_exists() {
Expand Down