refactor: write replica pid to file to fix flaky test#1175
Merged
mergify[bot] merged 2 commits intomasterfrom Nov 11, 2020
Merged
refactor: write replica pid to file to fix flaky test#1175mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
ghost
approved these changes
Nov 11, 2020
hansl
reviewed
Dec 8, 2020
| assert_no_dfx_start_or_replica_processes() { | ||
| ! ( ps | grep "[/[:space:]]dfx start" ) | ||
| ! ( ps | grep "[/[:space:]]replica" ) | ||
| ! ( ps | cat .dfx/replica-configuration/replica-pid ) |
Contributor
There was a problem hiding this comment.
That's not the right assertion. You need to grep the content of the file, not pipe into a cat (which is afaik no op)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the e2e test cases run in parallel,
REPLICA_PID=$(ps x | grep [/[:space:]]replica | awk '{print $1}')in start.bash could return the PID for the wrong replica process. Instead, dfx will now write the pid to file; the e2e test can read the file content to reliably kill the correct replica