Merged
Conversation
adamspofford-dfinity
force-pushed
the
spofford/arg-fix
branch
from
b3b9f9f to
eb49a23
Compare
ghost
suggested changes
Aug 29, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Can you describe what the bug was, in the PR description? What behavior would be seen, versus what the new (fixed) behaviour will be?
Contributor
Author
|
Fixed. |
ghost
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was introduced with
quill generatein #126 around the repetition of aclapargument. Because thepem_fileandseed_fileparameters were repeated twice in the same command, running the command would crash. This fixes it by removing the common flags from the command, as they are not used at all.