feat(governance): Added new TakeCanisterSnapshot NNS proposal type. #8283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
action-based-take-snapshot-daniel-wong
branch
from
139d543 to
5eb191c
Compare
daniel-wong-dfinity-org
force-pushed
the
action-based-take-snapshot-daniel-wong
branch
from
5eb191c to
1e760c5
Compare
This was referenced Jan 9, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
- Flag protected.
- Same as for standard new proposal types.
- Ditto.
- Requested.
jasonz-dfinity
approved these changes
Jan 9, 2026
Conflicts: - rs/nns/governance/src/pb/conversions/mod.rs :: Conflict seems to arrise from the fact that in master, some code was deleted right next to where I added some code. `git diff --cached master` seems to indicate that I preserved my addition while also preserving the deletion in master.
daniel-wong-dfinity-org
deleted the
action-based-take-snapshot-daniel-wong
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
# Previous Work This supercedes #8251. That one was based on a version of TakeCanisterSnapshot where we added a new NnsFunction. # References Closes [NNS1-4295]. [NNS1-4295]: https://dfinity.atlassian.net/browse/NNS1-4295 [👈 Previous PR][prev] [prev]: #8283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled by flag.
Previous Work
Previously, I tried to do this in PR 8228, but during code review, radical changes were requested; hence this new PR. Concretely, in the previous PR, the new proposal type was implemented as an NnsFunction; whereas, here, it is implemented as a direct Action. The rationale for switching is that the it was requested that the topic of this TakeCanisterSnapshot depend on the target canister, which means that the Governance canister cannot treat the arguments of the proposal as an opaque blob (when determining the proposal's topic).
References
Addresses NNS1-4295.
👈 Previous PR | Next PR 👉