feat(governance): New proposal type: TakeCanisterSnapshot. #8228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
take-snapshot-proposal-daniel-wong
branch
from
1db0ec0 to
afa1f8d
Compare
Contributor
Author
daniel-wong-dfinity-org
left a comment
daniel-wong-dfinity-org
left a comment
There was a problem hiding this comment.
Reviewer guide.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
- Done.
- Only in the usual sense: now, there is a new NnsFunction: in order for clients to make sense of the payload, they need to make code changes. OTOH, Candid libraries will decode just fine, even without code changes.
- Existing data is fine. No new requirements.
- Requesting review of broader feature, but for this PR, all is ok, since this feature is disabled by flag.
… this commit does is introduces the (canister) API and storage types. Disabled via flag; hence, this can be merged into master.
…t into a TakeCanisterSnapshotRequest.
daniel-wong-dfinity-org
force-pushed
the
take-snapshot-proposal-daniel-wong
branch
from
ef038fe to
29bd7e6
Compare
jasonz-dfinity
approved these changes
Jan 7, 2026
jasonz-dfinity
requested changes
Jan 7, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
auto-merge was automatically disabled
January 8, 2026 15:21
Pull request was closed
auto-merge was automatically disabled
January 9, 2026 10:51
Pull request was closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…8283) Disabled by flag. # Previous Work Previously, I tried to do this in [PR 8228], but during code review, radical changes were requested; hence this new PR. Concretely, in the previous PR, the new proposal type was implemented as an NnsFunction; whereas, here, it is implemented as a direct Action. The rationale for switching is that the it was requested that the topic of this TakeCanisterSnapshot depend on the target canister, which means that the Governance canister cannot treat the arguments of the proposal as an opaque blob (when determining the proposal's topic). [PR 8228]: #8228 # References Addresses [NNS1-4295]. [NNS1-4295]: https://dfinity.atlassian.net/browse/NNS1-4295 [👈 Previous PR][prev] | [Next PR 👉][next] [prev]: #8159 [next]: #8285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUPERCEDED BY #8283
Disabled (in production) via a flag.
Previous Work
In the previous PR, the Root canister was given a new method named
take_canister_snapshot, and that is where the (main) implementation of this new proposal type lives.Future Work
If there are Governance canister changes that are needed to execute this type of proposal, they'll be made in future changes. If not, I guess we can proceed directly to writing an integration test.
References
Addresses NNS1-4295.
👈 Previous PR | Next PR 👉