test(governance): Test TakeCanisterSnapshot (New) Proposal Type. #8251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
changed the base branch from
master
to
take-snapshot-proposal-daniel-wong
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
Just adding a test.
daniel-wong-dfinity-org
force-pushed
the
take-snapshot-proposal-daniel-wong
branch
from
ef038fe to
29bd7e6
Compare
daniel-wong-dfinity-org
force-pushed
the
test-take-canister-snapshot-proposal-daniel-wong
branch
2 times, most recently
from
67d97e3 to
0665cf3
Compare
jasonz-dfinity
approved these changes
Jan 7, 2026
Contributor
jasonz-dfinity
left a comment
jasonz-dfinity
left a comment
There was a problem hiding this comment.
Approving while assuming the changes for LoadCanisterSnapshot will be removed
rs/nns/governance/proto/ic_nns_governance/pb/v1/governance.proto
Outdated
Show resolved
Hide resolved
daniel-wong-dfinity-org
force-pushed
the
test-take-canister-snapshot-proposal-daniel-wong
branch
2 times, most recently
from
556c250 to
25f5248
Compare
daniel-wong-dfinity-org
force-pushed
the
test-take-canister-snapshot-proposal-daniel-wong
branch
from
25f5248 to
2045b62
Compare
daniel-wong-dfinity-org
force-pushed
the
test-take-canister-snapshot-proposal-daniel-wong
branch
from
29c127d to
9a58716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUPERCEDED BY #8285
Closes NNS1-4295.
👈 Previous PR