Skip to content

fix(deps): bump givenergy-modbus to 2.1.0b10#102

Closed
dewet22 wants to merge 1 commit into
mainfrom
bump/givenergy-modbus-2.1.0b10
Closed

fix(deps): bump givenergy-modbus to 2.1.0b10#102
dewet22 wants to merge 1 commit into
mainfrom
bump/givenergy-modbus-2.1.0b10

Conversation

@dewet22

@dewet22 dewet22 commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Automated bump triggered by givenergy-modbus@2.1.0b10.

Summary by CodeRabbit

  • Chores
    • Updated the givenergy-modbus library dependency to require a newer minimum version.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates the givenergy-modbus minimum version requirement from >=2.1.0b8 to >=2.1.0b10 in both the Home Assistant custom component manifest and the Python project configuration file, maintaining the <3.0.0 upper bound.

Changes

Dependency Version Update

Layer / File(s) Summary
GivenEnergy Modbus Version Bump
custom_components/givenergy_local/manifest.json, pyproject.toml
The givenergy-modbus minimum version constraint is updated from beta 8 to beta 10 in both files, with the upper bound <3.0.0 unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • dewet22/givenergy-hass#59: Both PRs adjust the givenergy-modbus dependency constraint in custom_components/givenergy_local/manifest.json and pyproject.toml (different version floors).
  • dewet22/givenergy-hass#57: Both PRs modify custom_components/givenergy_local/manifest.json to bump the givenergy-modbus minimum version constraint.
  • dewet22/givenergy-hass#68: Both PRs modify the givenergy-modbus version constraint in custom_components/givenergy_local/manifest.json.

Poem

🐰 A beta brew, from eight to ten,
Two configs dance, again, again!
Dependencies aligned with care,
Modbus flows through the air! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: bumping the givenergy-modbus dependency to version 2.1.0b10 across both manifest.json and pyproject.toml files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump/givenergy-modbus-2.1.0b10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'givenergy-modbus' dependency from version '2.1.0b8' to '2.1.0b10' in 'manifest.json', 'pyproject.toml', and 'uv.lock'. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@deepsource-io

deepsource-io Bot commented Jun 2, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 24692df...cfceed6 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jun 2, 2026 10:48a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@custom_components/givenergy_local/manifest.json`:
- Line 16: The manifest pins "givenergy-modbus>=2.1.0b10,<3.0.0" which fails
because 2.1.0b10 isn't on PyPI; update the constraint in
custom_components/givenergy_local/manifest.json (change the lower bound to the
latest published beta, e.g. "givenergy-modbus>=2.1.0b9,<3.0.0" or remove the
beta floor), mirror the same change in pyproject.toml so both files match, then
run the package metadata refresh command: uv sync --refresh-package
givenergy-modbus to update the lock/registry. Ensure the exact dependency string
"givenergy-modbus>=2.1.0b10,<3.0.0" is replaced consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c9b08c4f-4d2a-4dbf-ab49-b1ca87ba4a78

📥 Commits

Reviewing files that changed from the base of the PR and between 24692df and cfceed6.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • custom_components/givenergy_local/manifest.json
  • pyproject.toml

"issue_tracker": "https://github.com/dewet22/givenergy-hass/issues",
"requirements": [
"givenergy-modbus>=2.1.0b8,<3.0.0"
"givenergy-modbus>=2.1.0b10,<3.0.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify givenergy-modbus 2.1.0b10 exists and check release information

# Check if version exists on PyPI
echo "=== Checking PyPI for givenergy-modbus 2.1.0b10 ==="
curl -s https://pypi.org/pypi/givenergy-modbus/json | jq -r '.releases | keys[] | select(. >= "2.1.0b8" and . < "3.0.0")' | sort -V

# Get latest version info
echo -e "\n=== Latest version info ==="
curl -s https://pypi.org/pypi/givenergy-modbus/json | jq -r '.info | "Latest: \(.version)"'

# Check GitHub releases for changelogs
echo -e "\n=== Recent GitHub releases ==="
gh api repos/dewet22/givenergy-modbus/releases --jq '.[] | select(.tag_name | test("v2\\.1\\.0b(8|9|10)")) | "Tag: \(.tag_name)\nPublished: \(.published_at)\nChanges: \(.body)\n---"'

Repository: dewet22/givenergy-hass

Length of output: 773


Fix dependency floor: givenergy-modbus 2.1.0b10 isn’t published on PyPI

custom_components/givenergy_local/manifest.json sets the minimum to 2.1.0b10, but PyPI currently only exposes 2.1.0b8 and 2.1.0b9 (no 2.1.0b10 release), so installs/resolution will fail. GitHub has a v2.1.0b10 tag, but the release body/changelog is empty, so breaking-change/migration details can’t be reviewed.

"givenergy-modbus>=2.1.0b10,<3.0.0"
  • Update the constraint to the latest available beta on PyPI (or lower the floor) and then sync custom_components/givenergy_local/manifest.json with pyproject.toml and run uv sync --refresh-package givenergy-modbus.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@custom_components/givenergy_local/manifest.json` at line 16, The manifest
pins "givenergy-modbus>=2.1.0b10,<3.0.0" which fails because 2.1.0b10 isn't on
PyPI; update the constraint in custom_components/givenergy_local/manifest.json
(change the lower bound to the latest published beta, e.g.
"givenergy-modbus>=2.1.0b9,<3.0.0" or remove the beta floor), mirror the same
change in pyproject.toml so both files match, then run the package metadata
refresh command: uv sync --refresh-package givenergy-modbus to update the
lock/registry. Ensure the exact dependency string
"givenergy-modbus>=2.1.0b10,<3.0.0" is replaced consistently.

@dewet22

dewet22 commented Jun 2, 2026

Copy link
Copy Markdown
Owner Author

Superseded — the beta pin chain was consolidated and applied directly (latest via #106, pinning 2.1.0b15). givenergy-hass will move to a stable >=2.1.0,<3.0.0 pin once givenergy-modbus 2.1.0 is released, so these intermediate beta bumps are no longer needed. Closing to keep the queue tidy.

@dewet22 dewet22 closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant