Skip to content

fix(deps): bump givenergy-modbus to 2.1.0b10 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dewet22 wants to merge 1 commit into from
Closed

fix(deps): bump givenergy-modbus to 2.1.0b10 #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom_components/givenergy_local/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"iot_class": "local_polling",
"issue_tracker": "https://github.com/dewet22/givenergy-hass/issues",
"requirements": [
"givenergy-modbus>=2.1.0b8,<3.0.0"
"givenergy-modbus>=2.1.0b10,<3.0.0"

@coderabbitai coderabbitai Bot Jun 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify givenergy-modbus 2.1.0b10 exists and check release information

# Check if version exists on PyPI
echo "=== Checking PyPI for givenergy-modbus 2.1.0b10 ==="
curl -s https://pypi.org/pypi/givenergy-modbus/json | jq -r '.releases | keys[] | select(. >= "2.1.0b8" and . < "3.0.0")' | sort -V

# Get latest version info
echo -e "\n=== Latest version info ==="
curl -s https://pypi.org/pypi/givenergy-modbus/json | jq -r '.info | "Latest: \(.version)"'

# Check GitHub releases for changelogs
echo -e "\n=== Recent GitHub releases ==="
gh api repos/dewet22/givenergy-modbus/releases --jq '.[] | select(.tag_name | test("v2\\.1\\.0b(8|9|10)")) | "Tag: \(.tag_name)\nPublished: \(.published_at)\nChanges: \(.body)\n---"'

Repository: dewet22/givenergy-hass

Length of output: 773

Fix dependency floor: givenergy-modbus 2.1.0b10 isn’t published on PyPI

custom_components/givenergy_local/manifest.json sets the minimum to 2.1.0b10, but PyPI currently only exposes 2.1.0b8 and 2.1.0b9 (no 2.1.0b10 release), so installs/resolution will fail. GitHub has a v2.1.0b10 tag, but the release body/changelog is empty, so breaking-change/migration details can’t be reviewed.

"givenergy-modbus>=2.1.0b10,<3.0.0"
  • Update the constraint to the latest available beta on PyPI (or lower the floor) and then sync custom_components/givenergy_local/manifest.json with pyproject.toml and run uv sync --refresh-package givenergy-modbus.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@custom_components/givenergy_local/manifest.json` at line 16, The manifest
pins "givenergy-modbus>=2.1.0b10,<3.0.0" which fails because 2.1.0b10 isn't on
PyPI; update the constraint in custom_components/givenergy_local/manifest.json
(change the lower bound to the latest published beta, e.g.
"givenergy-modbus>=2.1.0b9,<3.0.0" or remove the beta floor), mirror the same
change in pyproject.toml so both files match, then run the package metadata
refresh command: uv sync --refresh-package givenergy-modbus to update the
lock/registry. Ensure the exact dependency string
"givenergy-modbus>=2.1.0b10,<3.0.0" is replaced consistently.

],
"version": "1.1.0"
}
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ version = "0.0.0"
description = "Home Assistant custom component for GivEnergy inverters via local Modbus TCP"
requires-python = ">=3.14.2"
dependencies = [
"givenergy-modbus>=2.1.0b8,<3.0.0",
"givenergy-modbus>=2.1.0b10,<3.0.0",
]

[dependency-groups]
Expand Down
8 changes: 4 additions & 4 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading