Release 1.1.0#68
Conversation
2.1 is expected to contain breaking API changes (command dispatch refactor, model-layer updates); cap now so users are not silently upgraded once 2.1.0 stable ships. Compatibility with 2.1 will be addressed as a separate minor release. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 3 minutes and 50 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the Home Assistant integration manifest to tighten the ChangesManifest Dependency and Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the manifest.json for the GivEnergy Local integration. It restricts the givenergy-modbus dependency version requirement to <2.1 (previously <3.0.0) and bumps the integration version from 1.0.2 to 1.1.0. There are no review comments, and I have no additional feedback to provide.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@custom_components/givenergy_local/manifest.json`:
- Line 12: The dependency upper bound for givenergy-modbus is inconsistent:
manifest.json pins "givenergy-modbus>=2.0.4,<2.1" while pyproject.toml allows
"<3.0.0"; make them consistent by updating pyproject.toml to use the same upper
bound "<2.1" (or alternatively change manifest.json to match if that is
intended) and regenerate the lockfile/CI dependencies so tests run against the
same range; ensure you update the givenergy-modbus spec in pyproject.toml (and
any poetry/lockfile) to match the manifest.json entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a3b2ae3b-4a89-4140-8a64-7d73c7c4deac
📒 Files selected for processing (1)
custom_components/givenergy_local/manifest.json
| "issue_tracker": "https://github.com/dewet22/givenergy-hass/issues", | ||
| "requirements": [ | ||
| "givenergy-modbus>=2.0.4,<3.0.0" | ||
| "givenergy-modbus>=2.0.4,<2.1" |
There was a problem hiding this comment.
I found one alignment issue with the dependency cap: this release caps givenergy-modbus at <2.1 in the runtime manifest, but pyproject.toml still declares givenergy-modbus>=2.0.4,<3.0.0, and uv.lock still records that same project requirement.
That means HA/HACS users are protected from a future 2.1 install, but the dev/test environment can still resolve 2.1 later. I would mirror the <2.1 cap in pyproject.toml and refresh uv.lock, so CI, local tests, Dependabot/uv updates, and runtime installs all exercise the same compatibility boundary.
Keeps pyproject.toml and manifest.json in sync; the lockfile is regenerated against the tightened constraint. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Summary
Version bump to 1.1.0 collecting the following changes since v1.0.2:
PlantCapabilitiesacross restarts — warm-start detection, advisory Repairs issue + reload on topology change,redetect_plantservice (Persist PlantCapabilities across restarts to skip re-detection #48)expose_recommended_entitiesservice — one-shot voice/LLM assistant exposure for 17 headline entities; voice assistant docs (Document Assist/LLM exposure for energy entities; consider opt-in auto-expose #65)requires-pythonfloor to>=3.14.2givenergy-modbusat<2.1— 2.1 is expected to include breaking API changes (command dispatch refactor); compatibility will be a separate minor releaseTest plan
v1.1.0→ release🤖 Generated with Claude Code
Summary by CodeRabbit