remove vscodetask and vscodelaunch, deprecate project.github

[yangcao77]

Signed-off-by: Stephanie [email protected]

What does this PR do?

remove vscodetask and vscodelaunch, deprecate project.github
remove vacodetask & vacodelaunch related tests and sample devfiles

What issues does this PR fix or reference?

#340
#344

Is your PR tested? Consider putting some instruction how to test your changes

Docs PR

[amisevsk]

I'm 👍 on the changes but I'm not sure they're fully complete -- on the CRDs side, this poses a bit of a problem in the conversion functions (as the removed command types obviously cannot be converted to v1alpha2).

The easiest approach is to remove vscode-related tasks from the conversion tests -- I can help implement that if you would like.

[amisevsk]

I opened yangcao77#1 into the PR branch to remove vscode tasks from conversion tests.

It's also worth noting that this PR effectively removes the tasks from v1alpha1 as well, since k8s clusters will store v1alpha2. Applying a v1alpha1 DevWorkspace with vscode tasks will silently drop them from the object.

[amisevsk]

LGTM, we should get approval from @l0rd and/or @davidfestal before merge

[mmulholla]

Test updates LGTM

[mmulholla]

Tests LGTM

[l0rd]

I haven't tested this PR but this was discussed and agreed during last Cabal so +1 to merge.

[elsony]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, elsony, l0rd, mmulholla, yangcao77
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment