remove vscodetask and vscodelaunch, deprecate project.github (#349)

* remove vscodetask and vscodelaunch, deprecate project.github

Signed-off-by: Stephanie <[email protected]>

* Remove VSCodeTask and VSCodeLaunch from coverage in conversion tests

Signed-off-by: Angel Misevski <[email protected]>

* Add deprecation and removal notice to vscode tasks in v1alpha1

Signed-off-by: Angel Misevski <[email protected]>

* run go fmt

Signed-off-by: Stephanie <[email protected]>

Co-authored-by: Angel Misevski <[email protected]>

Author: yangcao77

crds/workspace.devfile.io_devworkspaces.v1beta1.yaml

@@ -31,10 +31,6 @@ func getCommandAttributes(command *Command) map[string]string {
 		return command.Exec.Attributes
 	case command.Apply != nil:
 		return command.Apply.Attributes
-	case command.VscodeTask != nil:
-		return command.VscodeTask.Attributes
-	case command.VscodeLaunch != nil:
-		return command.VscodeLaunch.Attributes
 	case command.Composite != nil:
 		return command.Composite.Attributes
 	case command.Custom != nil:

crds/workspace.devfile.io_devworkspaces.yaml

@@ -86,10 +86,14 @@ type Command struct {
 	Apply *ApplyCommand `json:"apply,omitempty"`
 
 	// Command providing the definition of a VsCode Task
+	//
+	// Deprecated; removed in v1alpha2
 	// +optional
 	VscodeTask *VscodeConfigurationCommand `json:"vscodeTask,omitempty"`
 
 	// Command providing the definition of a VsCode launch action
+	//
+	// Deprecated; removed in v1alpha2
 	// +optional
 	VscodeLaunch *VscodeConfigurationCommand `json:"vscodeLaunch,omitempty"`
 

crds/workspace.devfile.io_devworkspacetemplates.v1beta1.yaml

@@ -27,10 +27,6 @@ func convertCommandTo_v1alpha2(src *Command, dest *v1alpha2.Command) error {
 		srcAttributes = src.Exec.Attributes
 	case src.Apply != nil:
 		srcAttributes = src.Apply.Attributes
-	case src.VscodeTask != nil:
-		srcAttributes = src.VscodeTask.Attributes
-	case src.VscodeLaunch != nil:
-		srcAttributes = src.VscodeLaunch.Attributes
 	case src.Composite != nil:
 		srcAttributes = src.Composite.Attributes
 	case src.Custom != nil:
@@ -76,12 +72,6 @@ func convertCommandFrom_v1alpha2(src *v1alpha2.Command, dest *Command) error {
 	case dest.Exec != nil:
 		dest.Exec.Attributes = destAttributes
 		dest.Exec.Id = id
-	case dest.VscodeLaunch != nil:
-		dest.VscodeLaunch.Attributes = destAttributes
-		dest.VscodeLaunch.Id = id
-	case dest.VscodeTask != nil:
-		dest.VscodeTask.Attributes = destAttributes
-		dest.VscodeTask.Id = id
 	}
 	return err
 }

crds/workspace.devfile.io_devworkspacetemplates.yaml

@@ -40,7 +40,7 @@ var componentFuzzFunc = func(component *Component, c fuzz.Continue) {
 }
 
 var commandFuzzFunc = func(command *Command, c fuzz.Continue) {
-	switch c.Intn(6) {
+	switch c.Intn(4) {
 	case 0:
 		c.Fuzz(&command.Apply)
 	case 1:
@@ -49,10 +49,6 @@ var commandFuzzFunc = func(command *Command, c fuzz.Continue) {
 		c.Fuzz(&command.Custom)
 	case 3:
 		c.Fuzz(&command.Exec)
-	case 4:
-		c.Fuzz(&command.VscodeLaunch)
-	case 5:
-		c.Fuzz(&command.VscodeTask)
 	}
 }
 
@@ -130,7 +126,7 @@ var parentComponentFuzzFunc = func(component *Component, c fuzz.Continue) {
 var parentCommandFuzzFunc = func(command *Command, c fuzz.Continue) {
 	// Do not generate Custom commands for Parents
 	// Also: commands in Parents cannot have attributes.
-	switch c.Intn(5) {
+	switch c.Intn(3) {
 	case 0:
 		c.Fuzz(&command.Apply)
 		if command.Apply != nil {
@@ -146,16 +142,6 @@ var parentCommandFuzzFunc = func(command *Command, c fuzz.Continue) {
 		if command.Exec != nil {
 			command.Exec.Attributes = nil
 		}
-	case 3:
-		c.Fuzz(&command.VscodeLaunch)
-		if command.VscodeLaunch != nil {
-			command.VscodeLaunch.Attributes = nil
-		}
-	case 4:
-		c.Fuzz(&command.VscodeTask)
-		if command.VscodeTask != nil {
-			command.VscodeTask.Attributes = nil
-		}
 	}
 }
 

pkg/apis/workspaces/v1alpha1/attributes_conversion.go

@@ -219,10 +219,6 @@ func convertParentCommandFrom_v1alpha2(src *v1alpha2.CommandParentOverride, dest
 		dest.Composite.Id = srcId
 	case src.Exec != nil:
 		dest.Exec.Id = srcId
-	case src.VscodeLaunch != nil:
-		dest.VscodeLaunch.Id = srcId
-	case src.VscodeTask != nil:
-		dest.VscodeTask.Id = srcId
 	}
 	return nil
 }

pkg/apis/workspaces/v1alpha1/commands.go

@@ -138,10 +138,6 @@ func convertPluginComponentCommandFrom_v1alpha2(src *v1alpha2.CommandPluginOverr
 		dest.Composite.Id = srcId
 	case src.Exec != nil:
 		dest.Exec.Id = srcId
-	case src.VscodeLaunch != nil:
-		dest.VscodeLaunch.Id = srcId
-	case src.VscodeTask != nil:
-		dest.VscodeTask.Id = srcId
 	}
 	return nil
 }