Skip to content

Commit 4d71398

Browse files
committed
remove vscodetask and vscodelaunch, deprecate project.github
Signed-off-by: Stephanie <[email protected]>
1 parent 283b0c5 commit 4d71398

File tree

49 files changed

+151
-6791
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+151
-6791
lines changed

crds/workspace.devfile.io_devworkspaces.v1beta1.yaml

Lines changed: 8 additions & 372 deletions
Large diffs are not rendered by default.

crds/workspace.devfile.io_devworkspaces.yaml

Lines changed: 8 additions & 372 deletions
Large diffs are not rendered by default.

crds/workspace.devfile.io_devworkspacetemplates.v1beta1.yaml

Lines changed: 8 additions & 363 deletions
Large diffs are not rendered by default.

crds/workspace.devfile.io_devworkspacetemplates.yaml

Lines changed: 8 additions & 363 deletions
Large diffs are not rendered by default.

pkg/apis/workspaces/v1alpha2/commands.go

Lines changed: 1 addition & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,12 @@ import (
77

88
// CommandType describes the type of command.
99
// Only one of the following command type may be specified.
10-
// +kubebuilder:validation:Enum=Exec;Apply;VscodeTask;VscodeLaunch;Composite;Custom
10+
// +kubebuilder:validation:Enum=Exec;Apply;Composite;Custom
1111
type CommandType string
1212

1313
const (
1414
ExecCommandType CommandType = "Exec"
1515
ApplyCommandType CommandType = "Apply"
16-
VscodeTaskCommandType CommandType = "VscodeTask"
17-
VscodeLaunchCommandType CommandType = "VscodeLaunch"
1816
CompositeCommandType CommandType = "Composite"
1917
CustomCommandType CommandType = "Custom"
2018
)
@@ -92,14 +90,6 @@ type CommandUnion struct {
9290
// +optional
9391
Apply *ApplyCommand `json:"apply,omitempty"`
9492

95-
// Command providing the definition of a VsCode Task
96-
// +optional
97-
VscodeTask *VscodeConfigurationCommand `json:"vscodeTask,omitempty"`
98-
99-
// Command providing the definition of a VsCode launch action
100-
// +optional
101-
VscodeLaunch *VscodeConfigurationCommand `json:"vscodeLaunch,omitempty"`
102-
10393
// Composite command that allows executing several sub-commands
10494
// either sequentially or concurrently
10595
// +optional
@@ -173,40 +163,6 @@ type CompositeCommand struct {
173163
Parallel bool `json:"parallel,omitempty"`
174164
}
175165

176-
// VscodeConfigurationCommandLocationType describes the type of
177-
// the location the configuration is fetched from.
178-
// Only one of the following component type may be specified.
179-
// +kubebuilder:validation:Enum=Uri;Inlined
180-
type VscodeConfigurationCommandLocationType string
181-
182-
const (
183-
UriVscodeConfigurationCommandLocationType VscodeConfigurationCommandLocationType = "Uri"
184-
InlinedVscodeConfigurationCommandLocationType VscodeConfigurationCommandLocationType = "Inlined"
185-
)
186-
187-
// +union
188-
type VscodeConfigurationCommandLocation struct {
189-
// Type of Vscode configuration command location
190-
// +
191-
// +unionDiscriminator
192-
// +optional
193-
LocationType VscodeConfigurationCommandLocationType `json:"locationType,omitempty"`
194-
195-
// Location as an absolute of relative URI
196-
// the VsCode configuration will be fetched from
197-
// +optional
198-
Uri string `json:"uri,omitempty"`
199-
200-
// Inlined content of the VsCode configuration
201-
// +optional
202-
Inlined string `json:"inlined,omitempty"`
203-
}
204-
205-
type VscodeConfigurationCommand struct {
206-
BaseCommand `json:",inline"`
207-
VscodeConfigurationCommandLocation `json:",inline"`
208-
}
209-
210166
type CustomCommand struct {
211167
LabeledCommand `json:",inline"`
212168

pkg/apis/workspaces/v1alpha2/projects.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ type ProjectSource struct {
7373
// +optional
7474
Git *GitProjectSource `json:"git,omitempty"`
7575

76-
// Project's GitHub source
76+
// Project's GitHub source. Deprecated, use `Git` instead
7777
// +optional
7878
Github *GithubProjectSource `json:"github,omitempty"`
7979

pkg/apis/workspaces/v1alpha2/zz_generated.deepcopy.go

Lines changed: 0 additions & 168 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)