Repository navigation
Repair wp/5.5 branch Actions: Replace wp-env's database check with a MariaDB health check - #598
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
added this pull request to stack #558
September 30, 2026 10:38
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
force-pushed
the
fix-actions-5.5/replace-db-check-with-healthcheck
branch
from
October 5, 2026 20:44
908c569 to
062824d
Compare
desrosj
force-pushed
the
fix-actions-5.5/replace-db-check-with-healthcheck
branch
2 times, most recently
from
October 6, 2026 15:46
1b7a0a9 to
71a50db
Compare
desrosj
removed this pull request from stack #558
October 6, 2026 16:14
desrosj
changed the base branch from
fix-actions-5.5/add-mariadb-version-option
to
fix-actions-5.5/create-wp-env-databases
October 6, 2026 16:14
desrosj
added this pull request to stack #632
October 6, 2026 16:15
desrosj
force-pushed
the
fix-actions-5.5/replace-db-check-with-healthcheck
branch
from
October 8, 2026 18:08
71a50db to
e4bdf08
Compare
desrosj
removed this pull request from stack #632
October 8, 2026 18:10
desrosj
force-pushed
the
fix-actions-5.5/replace-db-check-with-healthcheck
branch
from
October 8, 2026 18:11
e4bdf08 to
a9a5613
Compare
desrosj
added this pull request to stack #692
October 8, 2026 18:11
desrosj
removed this pull request from stack #692
October 9, 2026 19:59
desrosj
changed the base branch from
fix-actions-5.5/create-wp-env-databases
to
wp/5.5
October 9, 2026 20:00
desrosj
force-pushed
the
fix-actions-5.5/replace-db-check-with-healthcheck
branch
from
October 9, 2026 20:01
a9a5613 to
a7483bf
Compare
desrosj
changed the base branch from
wp/5.5
to
fix-actions-5.5/create-wp-env-databases
October 9, 2026 20:02
desrosj
added this pull request to stack #723
October 9, 2026 20:02
desrosj
marked this pull request as ready for review
October 16, 2026 17:25
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #723
October 16, 2026 17:36
desrosj
added this pull request to stack #739
October 16, 2026 17:36
desrosj
force-pushed
the
fix-actions-5.5/replace-db-check-with-healthcheck
branch
from
October 16, 2026 17:47
a7483bf to
c4f6c68
Compare
Owner
Author
|
Moved to WordPress#85010. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Ports WordPress#75046 ("wp-env: Fix MySQL startup race condition causing database connection errors") to this branch's
wp-env:mysqlandtests-mysqlservices get a health check, andwordpress/tests-wordpresswait for it withcondition: service_healthy.MARIADB_AUTO_UPGRADEis set so existing databases get the user the check needs.wp-env startno longer runswp db checkwith its retry loop and extra sleep.wp-env startisn't affected.Why?
wp db checkruns the MariaDB client in thewordpress:cliimage (11.8), which requires TLS, and WP-CLI passes--no-defaults, so it can't be turned off. MariaDB before 11.4 doesn't offer TLS by default, so with the10.5pin from #623 (directly above)wp-env startwould stop withTLS/SSL error: SSL is required, but the server does not support it. Trunk droppedwp db checkfor a health check that doesn't use the client at all.How?
depends_on,startandcleanfollow WordPress#75046 hunk for hunk, adapted to this branch's files. The health check itself is WordPress#83751's, because runninghealthcheck.shunconditionally fails on some versionsWP_ENV_MARIADB_VERSION(#576) can select: 10.2 and 10.3 lack the healthcheck user, and images from before 2022 (and old patch tags like10.5.8) lack the script. It runshealthcheck.shonly when both the script and.my-healthcheck.cnfexist, and otherwise pings over TCP on127.0.0.1withmariadb-adminormysqladmin.Testing
wp-envtests are ported;npm run test-unit -- packages/envpasses all 40 locally.mariadb:10.5throughhealthcheck.shand onmariadb:10.3through the ping fallback.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code