Repository navigation
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
added this pull request to stack #632
October 6, 2026 16:15
desrosj
force-pushed
the
fix-actions-5.5/create-wp-env-databases
branch
from
October 8, 2026 18:08
6713f9a to
4ea315e
Compare
desrosj
removed this pull request from stack #632
October 8, 2026 18:10
desrosj
force-pushed
the
fix-actions-5.5/create-wp-env-databases
branch
from
October 8, 2026 18:11
4ea315e to
fcdabf9
Compare
desrosj
added this pull request to stack #692
October 8, 2026 18:11
desrosj
removed this pull request from stack #692
October 9, 2026 19:59
desrosj
changed the base branch from
fix-actions-5.5/add-mariadb-version-option
to
wp/5.5
October 9, 2026 20:00
desrosj
force-pushed
the
fix-actions-5.5/create-wp-env-databases
branch
from
October 9, 2026 20:01
fcdabf9 to
2699d42
Compare
desrosj
changed the base branch from
wp/5.5
to
fix-actions-5.5/add-mariadb-version-option
October 9, 2026 20:02
desrosj
added this pull request to stack #723
October 9, 2026 20:02
desrosj
marked this pull request as ready for review
October 16, 2026 17:14
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #723
October 16, 2026 17:36
desrosj
added this pull request to stack #739
October 16, 2026 17:36
desrosj
force-pushed
the
fix-actions-5.5/create-wp-env-databases
branch
from
October 16, 2026 17:47
2699d42 to
9ebf842
Compare
Owner
Author
|
Moved to WordPress#85009. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Creates the
wordpressandtests-wordpressdatabases thatwp-envuses. Themysqlservice now setsMYSQL_DATABASE: wordpress, and a newtests-mysqlservice (samemariadb:${WP_ENV_MARIADB_VERSION:-latest}image, its ownmysql-testvolume) setsMYSQL_DATABASE: tests-wordpress.tests-wordpress,tests-cliandphpunitnow setWORDPRESS_DB_HOST: tests-mysql, andtests-cliandphpunitalso setWORDPRESS_DB_NAME: tests-wordpress.Why?
"Install WordPress" in the PHP unit test jobs fails with
Error: Can’t select database, because thewordpressdatabase does not exist. Themysqlservice only setsMYSQL_ALLOW_EMPTY_PASSWORD, so nothing creates either database: thewordpressimage's entrypoint used to runCREATE DATABASEfromWORDPRESS_DB_NAME, and docker-library/wordpress#557 removed that in January 2021. Below the health check PR (#598) this was hidden by the earlierwp db checkTLS failure.The
wp-config.phpthe image now writes reads every database setting withgetenv_docker(), so each container gets the values from its own environment. Reproduced locally with this branch'swp-envand the current images:tests-cliandphpunithave noWORDPRESS_DB_NAME, so they resolveDB_NAMEto thewordpressdefault, and the tests environment would be installed into the development database.cliresolves towordpressandmysqlby default, which is already right, so it is unchanged.How?
A minimal backport of the database part of #29800 (WordPress@f8052e1), which
wp/5.7and later already have. It keeps this branch's empty root password (MYSQL_ALLOW_EMPTY_PASSWORD,WORDPRESS_DB_PASSWORD: '') rather than switching toMYSQL_ROOT_PASSWORD, and leaves outmakeConfigWritable: thewordpressimage's entrypoint already makeswp-config.phpowned bywww-data, and everywp config setcall succeeds without it. #598 givestests-mysqlthe same health check andMARIADB_AUTO_UPGRADEasmysql, andtests-wordpresswaits fortests-mysqlto be healthy.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code