Repository navigation
Repair wp/5.5 branch Actions: Replace wp-env's database check with a MariaDB health check - #85010
Open
desrosj wants to merge 1 commit into
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #85017
October 16, 2026 20:10
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
This was referenced Oct 16, 2026
desrosj
marked this pull request as ready for review
October 19, 2026 13:19
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82938.
What?
Ports #75046 ("wp-env: Fix MySQL startup race condition causing database connection errors") to this branch's
wp-env:mysqlandtests-mysqlservices get a health check, andwordpress/tests-wordpresswait for it withcondition: service_healthy.MARIADB_AUTO_UPGRADEis set so existing databases get the user the check needs.wp-env startno longer runswp db checkwith its retry loop and extra sleep.wp-env startisn't affected.Why?
wp db checkruns the MariaDB client in thewordpress:cliimage (11.8), which requires TLS, and WP-CLI passes--no-defaults, so it can't be turned off. MariaDB before 11.4 doesn't offer TLS by default, so with the10.5pin from #85011 (directly above)wp-env startwould stop withTLS/SSL error: SSL is required, but the server does not support it. Trunk droppedwp db checkfor a health check that doesn't use the client at all.How?
depends_on,startandcleanfollow #75046 hunk for hunk, adapted to this branch's files. The health check itself is #83751's, because runninghealthcheck.shunconditionally fails on some versionsWP_ENV_MARIADB_VERSION(#85008) can select: 10.2 and 10.3 lack the healthcheck user, and images from before 2022 (and old patch tags like10.5.8) lack the script. It runshealthcheck.shonly when both the script and.my-healthcheck.cnfexist, and otherwise pings over TCP on127.0.0.1withmariadb-adminormysqladmin.Testing
wp-envtests are ported;npm run test-unit -- packages/envpasses all 40 locally.mariadb:10.5throughhealthcheck.shand onmariadb:10.3through the ping fallback.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code