Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Caddy file in to separate file #3765

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

MartijnCuppens
Copy link
Contributor

  • Move Caddyfile in to separate file to increase readability.
  • Make use of {{vars}} instead of $vars (realpath had to be set for deploy_path)

This might be the first step for a better configurable Caddyfile in the future.

@antonmedv antonmedv merged commit 857b8a4 into deployphp:master Jan 12, 2024
8 of 9 checks passed
@MartijnCuppens MartijnCuppens deleted the caddyfile-split branch January 12, 2024 11:27
midweste pushed a commit to midweste/deployer that referenced this pull request Jan 16, 2024
* upstream/master: (78 commits)
  [automatic] Update docs with bin/docgen
  Move Caddy file in to separate file (deployphp#3765)
  Create parent folders if needed (deployphp#3764)
  [automatic] Update docs with bin/docgen
  Switch to owner change instead of shh user change (deployphp#3763)
  Don't show warning if `become` parameter is set to `root` (deployphp#3761)
  [automatic] Update docs with bin/docgen
  Adding Spiral Framework recipe (deployphp#3582)
  Crontab: allow sudo with crontab:use_sudo option (deployphp#3759)
  fix: run cachetool without args (deployphp#3742)
  Fix version variables in Contao recipe (deployphp#3735)
  contrib: fix creating cron jobs first time
  Removing wrong information regarding reverse DNS (deployphp#3726)
  [automatic] Update docs with bin/docgen
  Fix issue provoked after adding array casting and returning empty fcgi parameter to the command (deployphp#3724)
  Revert "[TASK] Update TYPO3 recipe (deployphp#3674)" (deployphp#3723)
  ci-cd docs: update link to gitlab doc section (deployphp#3721)
  [automatic] Update docs with bin/docgen
  Fix test function (deployphp#3717)
  [automatic] Update docs with bin/docgen
  ...
@SimJoSt
Copy link
Contributor

SimJoSt commented May 9, 2024

Since this change, I am running into the following error when provisioning a new website:

ErrorException  in website.php on line 24:
    file_get_contents(./Caddyfile): Failed to open stream: No such file or directory

Did the change come with additional requirements that need to be fulfilled so the new system works?
If not, I'll create a proper bug report issue.
Downgrading to v7.3.3 resolved the problem.

@antonmedv
Copy link
Member

@MartijnCuppens please take a look!

@SimJoSt
Copy link
Contributor

SimJoSt commented Sep 20, 2024

Migrated to #3901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants