fix: run cachetool without args #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a regression bug introduced with deployphp@266554d
|
I chose to only accept a plain string or an array of strings for the |
|
@claytonrcarter please rake a look. |
claytonrcarter
approved these changes
Dec 6, 2023
| $return[] = "--fcgi={$option}"; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return $return; | ||
| return $return ?: ['']; |
There was a problem hiding this comment.
I had to double check, but [] ?: [''] returns [''], so this makes sense and it should resolve the issue I'm seeing in 7.3.3.
Thank you! 👍
midweste
pushed a commit
to midweste/deployer
that referenced
this pull request
Jan 16, 2024
* upstream/master: (78 commits) [automatic] Update docs with bin/docgen Move Caddy file in to separate file (deployphp#3765) Create parent folders if needed (deployphp#3764) [automatic] Update docs with bin/docgen Switch to owner change instead of shh user change (deployphp#3763) Don't show warning if `become` parameter is set to `root` (deployphp#3761) [automatic] Update docs with bin/docgen Adding Spiral Framework recipe (deployphp#3582) Crontab: allow sudo with crontab:use_sudo option (deployphp#3759) fix: run cachetool without args (deployphp#3742) Fix version variables in Contao recipe (deployphp#3735) contrib: fix creating cron jobs first time Removing wrong information regarding reverse DNS (deployphp#3726) [automatic] Update docs with bin/docgen Fix issue provoked after adding array casting and returning empty fcgi parameter to the command (deployphp#3724) Revert "[TASK] Update TYPO3 recipe (deployphp#3674)" (deployphp#3723) ci-cd docs: update link to gitlab doc section (deployphp#3721) [automatic] Update docs with bin/docgen Fix test function (deployphp#3717) [automatic] Update docs with bin/docgen ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a regression bug introduced with 266554d
Bug fix Breaking change in v7.3.2 & v7.3.3 for
cachetooltask #3741New feature? No
BC breaks? No, restores backward compatibility
Tests added?
Docs added?