Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version variables in Contao recipe #3735

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

ameotoko
Copy link
Contributor

  • Bug fix

This PR fixes default values of config variables contao_version and symfony_version.

Context:

When installed, Contao overrides output of Symfony's console command bin/console --version, so that it returns Contao's version instead of Symfony's. The only way the get Symfony's version in this case is to run bin/console about.

In addition, bin/console contao:version command is deprecated since Contao 4.13 (current LTS), and no longer works in Contao 5.2 (current latest). Thus, in Contao 4.13 both console --version and console contao:version show Contao's version and neither of them shows Symfony's. In Contao 5.2, console --version shows Contao's version, and console contao:version fails.

This PR fixes it by parsing output of bin/console --version into contao_version variable, and bin/console about – into symfony_version. The fix works for both Contao 4.13 and Contao 5.2 versions. The parsing is done in the same way as in the bare Symfony's recipe:

set('symfony_version', function () {
$result = run('{{bin/console}} --version');
preg_match_all('/(\d+\.?)+/', $result, $matches);
return $matches[0][0] ?? 5.0;
});

@antonmedv antonmedv merged commit 507f54c into deployphp:master Nov 27, 2023
9 checks passed
@ameotoko ameotoko deleted the fix/contao-version branch November 27, 2023 11:06
midweste pushed a commit to midweste/deployer that referenced this pull request Jan 16, 2024
* upstream/master: (78 commits)
  [automatic] Update docs with bin/docgen
  Move Caddy file in to separate file (deployphp#3765)
  Create parent folders if needed (deployphp#3764)
  [automatic] Update docs with bin/docgen
  Switch to owner change instead of shh user change (deployphp#3763)
  Don't show warning if `become` parameter is set to `root` (deployphp#3761)
  [automatic] Update docs with bin/docgen
  Adding Spiral Framework recipe (deployphp#3582)
  Crontab: allow sudo with crontab:use_sudo option (deployphp#3759)
  fix: run cachetool without args (deployphp#3742)
  Fix version variables in Contao recipe (deployphp#3735)
  contrib: fix creating cron jobs first time
  Removing wrong information regarding reverse DNS (deployphp#3726)
  [automatic] Update docs with bin/docgen
  Fix issue provoked after adding array casting and returning empty fcgi parameter to the command (deployphp#3724)
  Revert "[TASK] Update TYPO3 recipe (deployphp#3674)" (deployphp#3723)
  ci-cd docs: update link to gitlab doc section (deployphp#3721)
  [automatic] Update docs with bin/docgen
  Fix test function (deployphp#3717)
  [automatic] Update docs with bin/docgen
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants