Merged
Conversation
Member
|
Seems like the test failures are related to us using The errors are caused by our Gemfile and Gemfile.lock being out of sync I think we need to update it here too? dependabot-core/updater/Gemfile.lock Line 21 in 764839c We should probably update the license as well |
Member
Author
|
ah yeah, good ol' |
jeffwidman
force-pushed
the
bump-docker-registry2
branch
from
5ad5dc2 to
ef977a8
Compare
Member
Author
|
I think this is good to go for now. I'm not worried about bumping the license and would rather ignore it for now--we can pick that up later, when we add a CI check enforcing license update compliance, otherwise it'll just fall out of date again... |
Bump `docker_registry2` to `1.13` to pickup the fix in deitch/docker_registry2#68. This pin isn't strictly necessary since the upstream fix is mostly cosmetic making a stack trace more legible, so I originally wasn't going to force it. However, I removed the `>=` pin as it's redundant given the `~>` pin. It crept in originally as part of forcing a newer patch release in e991abb, but should have been removed by 0299755 / #5436. And since I was doing that, I figured I might as well bump it too.
jeffwidman
force-pushed
the
bump-docker-registry2
branch
from
ef977a8 to
1681631
Compare
Nishnha
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
docker_registry2to1.13to pickup the fix in deitch/docker_registry2#68.This pin isn't strictly necessary since the upstream fix is mostly cosmetic making a stack trace more legible, so I originally wasn't going to force it.
However, I removed the
>=pin as it's redundant given the~>pin. It crept in originally as part of forcing a newer patch release in e991abb, but should have been removed by 0299755 / #5436.And since I was doing that, I figured I might as well bump it too.