Keep updater lockfile in sync with subgem changes#5972
Merged
jeffwidman merged 1 commit intomainfrom Oct 25, 2022
Merged
Conversation
deivid-rodriguez
force-pushed
the
deivid-rodriguez/keep-updater-gemfile-in-sync
branch
from
d4393d9 to
04bc838
Compare
jeffwidman
approved these changes
Oct 25, 2022
Member
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Thanks!
Had one question about enforcing no drift, but if needed that can also be done as a separate PR, so approving this one.
By running bundler in frozen mode. This way Bundler will yell when it detects any changes in the lock file during `bundle install`.
jeffwidman
force-pushed
the
deivid-rodriguez/keep-updater-gemfile-in-sync
branch
from
04bc838 to
994c5da
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a big problem, specially now that we're not pushing new gems to rubygems.org. But the lock file could still get out of sync unintentionally and this should prevent that.
This should clear #5858 from any changes other than the Bundler upgrade.