Add useful error message for DockerRegistry2::NotFound#68
Merged
deitch merged 1 commit intodeitch:masterfrom Dec 12, 2022
blue2cat:private-image-error-message
Merged
Add useful error message for DockerRegistry2::NotFound#68deitch merged 1 commit intodeitch:masterfrom blue2cat:private-image-error-message
deitch merged 1 commit intodeitch:masterfrom
blue2cat:private-image-error-message
Conversation
Contributor
Author
|
I'm having some trouble testing my changes. When I try to run the test script at I've run |
deitch
approved these changes
Nov 17, 2022
Owner
|
Hmm, I am not sure. CI does it fully isolated, so if it comes out clean, try copying it? |
|
Resolves #67 |
Contributor
Author
|
I solved the dependency issue and tested my changes. The screenshot below shows the output when |
deitch
approved these changes
Nov 28, 2022
Owner
|
Can you just squash to a single commit? |
Contributor
Author
|
Commits squashed. Looks like there is a small conflict with changes introduced in #70. |
Owner
|
So just rebase and override it. |
deitch
approved these changes
Dec 11, 2022
Owner
|
Looks like a linting error. |
Avoid a stack trace when a nonexistent private image is encountered.
Contributor
Author
|
Sorry about that, I've run RuboCop locally and fixed the linting issue (Trailing whitespace). |
deitch
approved these changes
Dec 12, 2022
Owner
|
Thanks @blue2cat |
|
Any chance of a release that includes this fix? |
Owner
|
Done |
|
Thanks! |
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Mar 22, 2023
Bump `docker_registry2` to `1.13` to pickup the fix in deitch/docker_registry2#68. This pin isn't strictly necessary since the upstream fix is mostly cosmetic making a stack trace more legible, so I originally wasn't going to force it. However, I removed the `>=` pin as it's redundant given the `~>` pin. It crept in originally as part of forcing a newer patch release in e991abb, but should have been removed by 0299755 / #5436. And since I was doing that, I figured I might as well bump it too.
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Mar 22, 2023
* Bump `docker_registry2` to `1.13` Bump `docker_registry2` to `1.13` to pickup the fix in deitch/docker_registry2#68. This pin isn't strictly necessary since the upstream fix is mostly cosmetic making a stack trace more legible, so I originally wasn't going to force it. However, I removed the `>=` pin as it's redundant given the `~>` pin. It crept in originally as part of forcing a newer patch release in e991abb, but should have been removed by 0299755 / #5436. And since I was doing that, I figured I might as well bump it too. * `cd updater && bundle install`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid a stack trace when a nonexistent private image is encountered.