Skip to content

Go: handle missing import error and submodule cloning failure error#6740

Merged
jakecoffman merged 1 commit intomainfrom
jakecoffman/go-related-bugs
Feb 27, 2023
Merged

Go: handle missing import error and submodule cloning failure error#6740
jakecoffman merged 1 commit intomainfrom
jakecoffman/go-related-bugs

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

Continuing the effort from #6730 to categorize known errors that we can't fix.

I'm seeing "package \S+ is not in GOROOT" quite a bit which indicates a relative import path that is not present. For instance, the package is named web and there's an import web/package where the directory package doesn't exist. This might be because they have generated code that isn't checked in, which is against Go conventions, so I don't think we need to try to support it:

once the file is generated (and tested!) it must be checked into the source code repository to be available to clients
--https://go.dev/blog/generate

Also fixing a NilClass bug introduced in #6172. The original intent was to check for the match in this unless, so when an error mentioning submodules occurs but didn't match the regex it would raise an error instead of failing with the SharedHelpers exception.

@jakecoffman jakecoffman requested a review from a team as a code owner February 27, 2023 13:41
@jakecoffman jakecoffman merged commit c49b3f9 into main Feb 27, 2023
@jakecoffman jakecoffman deleted the jakecoffman/go-related-bugs branch February 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants