Go: handle missing import error and submodule cloning failure error#6740
Merged
jakecoffman merged 1 commit intomainfrom Feb 27, 2023
Merged
Go: handle missing import error and submodule cloning failure error#6740jakecoffman merged 1 commit intomainfrom
jakecoffman merged 1 commit intomainfrom
Conversation
landongrindheim
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the effort from #6730 to categorize known errors that we can't fix.
I'm seeing "package \S+ is not in GOROOT" quite a bit which indicates a relative import path that is not present. For instance, the package is named
weband there's an importweb/packagewhere the directorypackagedoesn't exist. This might be because they have generated code that isn't checked in, which is against Go conventions, so I don't think we need to try to support it:Also fixing a NilClass bug introduced in #6172. The original intent was to check for the match in this
unless, so when an error mentioning submodules occurs but didn't match the regex it would raise an error instead of failing with the SharedHelpers exception.