Skip to content

Go: handle missing import error and submodule cloning failure error #6740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakecoffman merged 1 commit into from
Feb 27, 2023
+4 −2
Merged

Go: handle missing import error and submodule cloning failure error #6740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/lib/dependabot/file_fetchers/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ def _clone_repo_contents(target_directory:)
CMD
)
rescue SharedHelpers::HelperSubprocessFailed => e
raise unless GIT_SUBMODULE_ERROR_REGEX && e.message.downcase.include?("submodule")
raise unless e.message.match(GIT_SUBMODULE_ERROR_REGEX) && e.message.downcase.include?("submodule")

submodule_cloning_failed = true
match = e.message.match(GIT_SUBMODULE_ERROR_REGEX)
Expand Down
4 changes: 3 additions & 1 deletion go_modules/lib/dependabot/go_modules/file_updater/go_mod_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ class GoModUpdater
/malformed module path/,
/used for two different module paths/,
# https://github.com/golang/go/issues/56494
/can't find reason for requirement on/
/can't find reason for requirement on/,
# import path doesn't exist
/package \S+ is not in GOROOT/
].freeze

REPO_RESOLVABILITY_ERROR_REGEXES = [
Expand Down