submodule cloning may not be important to the job, ignore errors#6172
Merged
jakecoffman merged 1 commit intomainfrom Nov 28, 2022
Merged
submodule cloning may not be important to the job, ignore errors#6172jakecoffman merged 1 commit intomainfrom
jakecoffman merged 1 commit intomainfrom
Conversation
jakecoffman
force-pushed
the
jakecoffman/ignore-submodule-cloning-errors
branch
from
7070ba2 to
f8ee856
Compare
landongrindheim
approved these changes
Nov 28, 2022
Contributor
There was a problem hiding this comment.
👌 I can picture this being really helpful 😄
jakecoffman
force-pushed
the
jakecoffman/ignore-submodule-cloning-errors
branch
from
5075dbc to
a2de2d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5982 we enabled submodule cloning by default. However, sometimes a repo has a submodule that is inaccessible to Dependabot that is unrelated to dependencies.
We talked about adding a flag to disable it, but it's nice when Dependabot just works.
So for this PR I took the approach to just ignore the submodule clone errors and continue with the update. That way if it was not important, it will succeed in doing the update.
If it was important it will fail later, but I added an error log that says the nature of the failure during the fetch as a hint as to what might be wrong.