submodule cloning may not be important to the job, ignore errors#6228
Merged
jakecoffman merged 3 commits intomainfrom Nov 29, 2022
Merged
Conversation
jakecoffman
force-pushed
the
jakecoffman/ignore-submodule-failures-again-part-2
branch
from
3b7dd3d to
345aabc
Compare
landongrindheim
approved these changes
Nov 28, 2022
jakecoffman
deleted the
jakecoffman/ignore-submodule-failures-again-part-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6172 I missed that having SCP-style URLs in the
.gitmoduleswould have a different error message.So this checks for both error messages and ignores so that the update can attempt to proceed in the event the submodules were not important to the update.