Merged
Conversation
jeffwidman
force-pushed
the
fix-regenerating-bundler-lockfile-in-updater
branch
from
aca0324 to
ef70288
Compare
jeffwidman
commented
Oct 9, 2022
I noticed the following log lines in [the output of building the `updater`](https://github.com/dependabot/dependabot-core/actions/runs/3212248230/jobs/5250946524) Docker image: ``` 32 sha256:563a023320753425444761bd82772c641463b33ea716db65998c70bdc931dd95 32 1.167 Bundler 2.3.22 is running, but your lockfile was generated with 2.2.20. Installing Bundler 2.2.20 and restarting using that version. 32 2.192 Fetching gem metadata from https://rubygems.org/. 32 2.217 Fetching bundler 2.2.20 32 2.297 Installing bundler 2.2.20 32 2.511 Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead. 32 3.308 Fetching gem metadata from https://rubygems.org/......... ``` That's probably because of #5509 which updated `bundler` to `2.3.22` which doesn't match the version of Bundler specified in `Gemfile.lock`: * https://bundler.io/blog/2022/01/23/bundler-v2-3.html * https://github.com/dependabot/dependabot-core/blob/2ba96fcc09564675d94140b7f8ee6fefa32de935/updater/Gemfile.lock#L333 So I built the docker updater image (couldn't use the core image unfortunately because it doesn't mount `/updater`, and for good reason). And then within that docker image ran: ``` $ bundler update --bundler ```
jeffwidman
force-pushed
the
fix-regenerating-bundler-lockfile-in-updater
branch
from
ef70288 to
1eff60f
Compare
bdragon
approved these changes
Oct 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the following log lines in the output of building the
updaterDocker image:That's probably because of
#5509 which updated
bundlerto2.3.22which doesn't match the version of Bundler specified inGemfile.lock:dependabot-core/updater/Gemfile.lock
Line 333 in 2ba96fc
So I built the docker updater image (couldn't use the core image unfortunately because it doesn't mount
/updater, and for good reason).And then within that docker image ran: