disable build isolation to allow custom setuptools versions#5545
Closed
jakecoffman wants to merge 1 commit intomainfrom
Closed
disable build isolation to allow custom setuptools versions#5545jakecoffman wants to merge 1 commit intomainfrom
jakecoffman wants to merge 1 commit intomainfrom
Conversation
Closed
Contributor
|
@jurre let me know #5540 (comment) that this retry is relatively expensive, so I would think we wouldn't want to always retry if it is an error we know we can't recover from |
Member
|
Yeah, I guess it's better than a broken update, but if we can avoid it that would probably be preferable |
Member
Author
|
#5546 makes the most sense at this point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original retry logic was introduced in #2815.
We're now seeing a new reason why retrying without build isolation when setuptools doesn't work with the library being compiled.
So I figured we could just retry regardless of what the specific error is in the helpers rather than chasing the error of the day 😄