Fix building native python dependencies for pip-compile#2815
Merged
Conversation
feelepxyz
reviewed
Dec 3, 2020
python/lib/dependabot/python/update_checker/pip_compile_version_resolver.rb
Outdated
Show resolved
Hide resolved
jurre
force-pushed
the
jurre/fix-pip-compile-native-dependencies
branch
from
aff4979 to
05af702
Compare
Some native python dependencies require to be built from scratch, because no Wheel is available for them for the given version of Python. If this is the case, when trying to install with the `--build-isolation` flag, pip requires all the dependencies are available as wheels, but this is often not the case. Building with the `--no-build-isolation` ensures that any transitive dependencies are also installed/compiled from source.
jurre
force-pushed
the
jurre/fix-pip-compile-native-dependencies
branch
from
05af702 to
21ed214
Compare
jurre
changed the title
Member
Author
|
We'll probably want to do something similar for regular pip builds, but no reason we should hold off merging the fix for pip compile IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some native python dependencies require to be built from scratch,
because no Wheel is available for them for the given version of Python.
If this is the case, when trying to install with the
--build-isolationflag, pip requires all the dependencies are available as wheels, but
this is often not the case.
Building with the
--no-build-isolationensures that any transitivedependencies are also installed/compiled from source.