Skip to content

Try fix spec failure due to broken setuptools#5546

Merged
pavera merged 1 commit intomainfrom
deivid-rodriguez/setuptools
Aug 16, 2022
Merged

Try fix spec failure due to broken setuptools#5546
pavera merged 1 commit intomainfrom
deivid-rodriguez/setuptools

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez commented Aug 16, 2022

Just trying to fix CI, like others 😆

This spec is currently locked to numpy 0.19 which did not yet restrict setuptools version. I tried to make sure it uses the latest numpy which does restrict it. I left requirements.txt untouched because I can't for the love of me regenerate it from the updated requirements.in, since I have no idea what I'm doing. But this change alone fixed the spec locally, so I may as well try it in CI 🤷.

Spec is currently locked to numpy 0.19 which did not yet restrict
setuptools version. Now it does.
@jakecoffman jakecoffman mentioned this pull request Aug 16, 2022
@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Oh, I think I might get it. This spec is testing a project that does not resolve. So basically the requirements.txt file is unused since it fails to be regenerated. I'm going to try remove it to prove it.

Copy link
Copy Markdown
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense!

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Aug 16, 2022

That didn't work. Without requirements.txt, no resolution error happens at all.

I think pip compile does something similar to Bundler, it tracks changes in the requirements.in with respect to the existing requirement.txt and tries to keep everything in requirements.txt not affected by those changes locked. And it's probably those locked requirements causing the resolution conflict being tested here.

So I guess this PR makes sense as is, since it does not seem to affect the resolution but forces a good version of setuptools to be used.

@pavera pavera marked this pull request as ready for review August 16, 2022 18:31
@pavera pavera requested a review from a team as a code owner August 16, 2022 18:31
@pavera pavera merged commit dea1009 into main Aug 16, 2022
@pavera pavera deleted the deivid-rodriguez/setuptools branch August 16, 2022 18:48
@jeffwidman
Copy link
Copy Markdown
Member

That didn't work. Without requirements.txt, no resolution error happens at all.

I suspect this was fixed in #5580. @deivid-rodriguez Does that change anything that you were trying to do in this PR?

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

I tried removing the requirements.txt file and the spec failed so I think it didn't change anything. I think what I was trying to do was wrong, as per my theory at #5546 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants