Skip to content

[Python] Cache client-side timeouts when a remote host is unreachable#5374

Merged
brrygrdn merged 1 commit intomainfrom
brrygrdn/cache-timeouts-for-python
Jul 21, 2022
Merged

[Python] Cache client-side timeouts when a remote host is unreachable#5374
brrygrdn merged 1 commit intomainfrom
brrygrdn/cache-timeouts-for-python

Conversation

@brrygrdn
Copy link
Copy Markdown
Contributor

Follows up on #5142
See: #5373

This PR modifies the timeout caching strategy we used for Maven into a generic 'Dependabot::RegistryClient' and then applies it to the python gem to ship this strategy for another ecosystem.

Python is currently in the two three ecosystems experiencing this issue, but it's a little lower frequency than NPM so it might be worth shipping this first.

@brrygrdn brrygrdn force-pushed the brrygrdn/cache-timeouts-for-python branch 2 times, most recently from ed3c5a3 to 86e2108 Compare July 13, 2022 16:20
@brrygrdn brrygrdn marked this pull request as ready for review July 13, 2022 16:23
@brrygrdn brrygrdn requested a review from a team as a code owner July 13, 2022 16:23
@brrygrdn brrygrdn force-pushed the brrygrdn/cache-timeouts-for-python branch from 86e2108 to d36c437 Compare July 13, 2022 17:33
@brrygrdn brrygrdn force-pushed the brrygrdn/cache-timeouts-for-python branch from d36c437 to 05bbf1f Compare July 14, 2022 11:11
Copy link
Copy Markdown
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this against #5373 and it LGTM

@brrygrdn brrygrdn merged commit 154b6b6 into main Jul 21, 2022
@brrygrdn brrygrdn deleted the brrygrdn/cache-timeouts-for-python branch July 21, 2022 09:52
@brrygrdn brrygrdn mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants