[NPM/YARN] Cache client-side timeouts when a remote host is unreachable#5373
Merged
[NPM/YARN] Cache client-side timeouts when a remote host is unreachable#5373
Conversation
jurre
reviewed
Jul 13, 2022
jurre
reviewed
Jul 13, 2022
jurre
approved these changes
Jul 13, 2022
Member
jurre
left a comment
There was a problem hiding this comment.
This approach makes sense to me 👍
This was referenced Jul 13, 2022
Co-authored-by: Jurre <jurre@github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #5142
This PR modifies the timeout caching strategy we used for Maven into a generic 'Dependabot::RegistryClient' and then applies it to the
npm_and_yarngem to ship this strategy for another ecosystem.NPM is currently the ecosystem experiencing this problem most often, so let's address it next.
Alternatives considered
I originally approached this as an Excon middleware, but there were a few issues with that approach in my opinion: