Conversation
mattt
force-pushed
the
mattt/ruby-install
branch
from
7229f1a to
9f431bf
Compare
mattt
force-pushed
the
mattt/ruby-install
branch
from
9f431bf to
be4fd82
Compare
|
I think this is the right approach, thanks for taking this on, I've actually been meaning to do this for so long! I believe there's a little syntax issue with the Dockerfile that we need to patch up, but other than that looks good! |
landongrindheim
left a comment
landongrindheim
left a comment
There was a problem hiding this comment.
Great improvement 🏆
| ARG BUNDLER_V1_VERSION=1.17.3 | ||
| ARG BUNDLER_V2_VERSION=2.3.13 |
There was a problem hiding this comment.
I really like this update 🥇
💡 Seeing this change makes me wonder if we could take it further. What do you think about making these ENV variables, then pointing the references in our code (example) to BUNDER_Vx_VERSION? If you're interested, I think a followup PR would be a great fit for the change 🙂
There was a problem hiding this comment.
I don't fully recall the whole thing from my work on #4973, but I'm pretty sure if BUNDLER_VERSION is used is because RubyGems actually uses that ENV variable to activate the proper Bundler version. So if I understood what you mean, I think it would not work as expected. But if we introduced something like #4973 it wouldn't be needed anyways.
Co-authored-by: Jurre <jurre@github.com>
4 participants
Alternative to #5190.
Related to #5031 (comment).
Currently, we use the Brightbox PPA to install Ruby with
apt. However, this limits our ability to update to a more recent patch release of Ruby 2.7 (or later, Ruby 3).This PR updates this step in
Dockerfileto instead use ruby-install to install Ruby versions. I used Ruby 2.7.5 to match the version installed now. As a follow-up, we should upgrade to 2.7.6.