improve worst case image build time#7014
Merged
jakecoffman merged 12 commits intomainfrom Apr 6, 2023
Merged
Conversation
Member
Author
|
An uncached build time of 1:30-1:40 for most ecosystems! This would probably also greatly reduce an ARM emulated build. |
jakecoffman
force-pushed
the
jakecoffman/ruby-from-ruby-image
branch
from
7e8b491 to
5b86853
Compare
Member
Author
|
@pavera Do you think we could do something similar with Python? Might be hacky since we depend on pyenv. |
jeffwidman
approved these changes
Apr 6, 2023
Member
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Clever.
Feels a little risky to me, but I assume the official Ruby binary is statically linked?
I know one thing we'd also discussed before was the idea of using the pre-compiled binary that the GitHub Actions team maintains... this seems more straightforward though...
go_modules/spec/dependabot/go_modules/update_checker/latest_version_finder_spec.rb
Outdated
Show resolved
Hide resolved
deivid-rodriguez
approved these changes
Apr 6, 2023
Contributor
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
This is really awesome! I had the same idea for Python and did give it a try but couldn't make it work.
jeffwidman
approved these changes
Apr 6, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5356 we switched away from a PPA since it wasn't keeping up with new versions of Ruby. Ruby-install was good but building from source is slow, and it seems like we break the cache more often than we care to.
This approach is to copy Ruby et al from the official Ruby Docker image which should stay up-to-date. This allows us to skip the build to save time, and we can stay on our current version of Ubuntu by copying out the binaries. This also saves ~100MB from somewhere, the
bundlerimage is now around 640MB for me.I had to move the
bundle installout since it didn't seem to like to be run on a different version of Ubuntu? I'm not sure, but even with less parallelism this is very fast locally. Submitting as Draft to test against CI, check the speed, and get feedback.