Skip to content

Bump Ruby to 2.7.6#5157

Closed
yeikel wants to merge 1 commit intodependabot:mainfrom
yeikel:patch-1
Closed

Bump Ruby to 2.7.6#5157
yeikel wants to merge 1 commit intodependabot:mainfrom
yeikel:patch-1

Conversation

@yeikel
Copy link
Copy Markdown
Contributor

@yeikel yeikel commented May 17, 2022

No description provided.

@yeikel yeikel requested a review from a team as a code owner May 17, 2022 18:32
RUN apt-add-repository ppa:brightbox/ruby-ng \
&& apt-get update \
&& apt-get install -y --no-install-recommends ruby2.7 ruby2.7-dev \
&& apt-get install -y --no-install-recommends ruby2.7.6 ruby2.7.6-dev \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Brightbox nor Ubuntu provides these packages. I think the way to upgrade would be to migrate to ubuntu 22.04, which provides Ruby 3. Alternatively, copy installation commands from the official docker Ruby images, which would give more flexibility on the version that we use.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the 22.04 upgrade is already tracked in #5030, although even once CI passes there may be some internal-to-GitHub issues like packaging or security that may delay upgrading.

Ruby 3 is an interesting idea, but probably a bigger conversation. I'll try to remember to check with the rest of the team this coming week to see what the current plan is re: moving to Ruby 3.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Regardless of the update to 22.04 and/or to Ruby 3, it would seem like a good move to migrate to Ruby 2.7.6, the latest security release in the 2.7 series.

In order to achieve that, I think the best way would be to move away from Brightbox. The alternatives I can think of are:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I meant to add a comment explaining that this was meant fo open the conversation about the upgrade. I wanted to see the feedback from the CI

@mattt
Copy link
Copy Markdown
Contributor

mattt commented Jul 12, 2022

Thanks for your contribution with this PR, @yeikel. We recently merged #5356, which updates our image to use ruby-install instead of apt. This allowed us to update to 2.7.6 with #5364.

@mattt mattt closed this Jul 12, 2022
@yeikel yeikel deleted the patch-1 branch August 12, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants