Skip to content

Bump Ruby to 2.7.6 #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yeikel wants to merge 1 commit into from
Closed

Bump Ruby to 2.7.6 #5157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ RUN if ! getent group "$USER_GID"; then groupadd --gid "$USER_GID" dependabot ;

### RUBY

# Install Ruby 2.7, update RubyGems, and install Bundler
# Install Ruby 2.7.6, update RubyGems, and install Bundler
ENV BUNDLE_SILENCE_ROOT_WARNING=1
# Disable the outdated rubygems installation from being loaded
ENV DEBIAN_DISABLE_RUBYGEMS_INTEGRATION=true
Expand All @@ -75,11 +75,11 @@ ENV BUNDLE_PATH=".bundle" \
ENV PATH="$BUNDLE_BIN:$PATH:$BUNDLE_PATH/bin"
RUN apt-add-repository ppa:brightbox/ruby-ng \
&& apt-get update \
&& apt-get install -y --no-install-recommends ruby2.7 ruby2.7-dev \
&& apt-get install -y --no-install-recommends ruby2.7.6 ruby2.7.6-dev \
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Brightbox nor Ubuntu provides these packages. I think the way to upgrade would be to migrate to ubuntu 22.04, which provides Ruby 3. Alternatively, copy installation commands from the official docker Ruby images, which would give more flexibility on the version that we use.

Copy link
Copy Markdown
Member

@jeffwidman jeffwidman May 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the 22.04 upgrade is already tracked in #5030, although even once CI passes there may be some internal-to-GitHub issues like packaging or security that may delay upgrading.

Ruby 3 is an interesting idea, but probably a bigger conversation. I'll try to remember to check with the rest of the team this coming week to see what the current plan is re: moving to Ruby 3.

Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Regardless of the update to 22.04 and/or to Ruby 3, it would seem like a good move to migrate to Ruby 2.7.6, the latest security release in the 2.7 series.

In order to achieve that, I think the best way would be to move away from Brightbox. The alternatives I can think of are:

Copy link
Copy Markdown
Contributor Author

@yeikel yeikel Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I meant to add a comment explaining that this was meant fo open the conversation about the upgrade. I wanted to see the feedback from the CI

&& gem update --system 3.2.20 \
&& gem install bundler -v 1.17.3 --no-document \
&& gem install bundler -v 2.3.13 --no-document \
&& rm -rf /var/lib/gems/2.7.0/cache/* \
&& rm -rf /var/lib/gems/2.7.6/cache/* \
&& rm -rf /var/lib/apt/lists/*


Expand Down