Skip to content

Fixing issue with nuget devDependency support#4774

Merged
jeffwidman merged 5 commits intodependabot:mainfrom
pangaeatech:nuget_dev_bugfix
Sep 22, 2022
Merged

Fixing issue with nuget devDependency support#4774
jeffwidman merged 5 commits intodependabot:mainfrom
pangaeatech:nuget_dev_bugfix

Conversation

@mwaddell
Copy link
Copy Markdown
Contributor

I didn't fully wire-up the new development support in #4671 - this PR addresses that oversight

@mwaddell mwaddell marked this pull request as ready for review February 28, 2022 16:27
@mwaddell mwaddell requested a review from a team as a code owner February 28, 2022 16:27
@mctofu mctofu added the L: dotnet:nuget NuGet packages via nuget or dotnet label Mar 12, 2022
Copy link
Copy Markdown
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the nuget ecosystem, but this looks very straightforward to me.

@jeffwidman
Copy link
Copy Markdown
Member

@mwaddell can you please give maintainers the permissions to edit your PR so that we can get it up to date to merge it?

We currently only allow PR's to merge that are up to date with main.

@jeffwidman jeffwidman merged commit 04741be into dependabot:main Sep 22, 2022
@jeffwidman
Copy link
Copy Markdown
Member

Thanks @mwaddell and sorry again for the delay on this one.

@mwaddell
Copy link
Copy Markdown
Contributor Author

No worries - thanks for getting it merged!

@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: dotnet:nuget NuGet packages via nuget or dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants