Adding "devDependencies" support for nuget projects.#4671
Adding "devDependencies" support for nuget projects.#4671feelepxyz merged 5 commits intodependabot:mainfrom pangaeatech:pangaeatech/nuget-devSupport
Conversation
- Addresses issue #4659 - Supports `ItemGroup > DevelopmentDependency` groups in `.csproj` files - Supports `developmentDependency="true"` in `packages.config` - Does **not** support development dependencies specified using the `Condition=` property in `<Import />`, etc.
| doc.css(DEV_SELECTOR).each do |dependency_node| | ||
| name = dependency_name(dependency_node, project_file) | ||
| req = dependency_requirement(dependency_node, project_file) | ||
| version = dependency_version(dependency_node, project_file) | ||
| prop_name = req_property_name(dependency_node) | ||
|
|
||
| dependency = build_dependency(name, req, version, prop_name, project_file, true) | ||
| dependency_set << dependency if dependency | ||
| end |
There was a problem hiding this comment.
Could this be folded into the existing dependency selector and checking the dependency_node to see if it's a dev dependency?
There was a problem hiding this comment.
Yep, I just pushed that change for your review.
Co-authored-by: Philip Harrison <philip@mailharrison.com>
feelepxyz
left a comment
feelepxyz
left a comment
There was a problem hiding this comment.
Thanks for tackling this and going through all the specs! I've done a quick pass and looks good overall, wondering if the added doc.css(DEV_SELECTOR).each is needed or could be folder into the existing doc.css(DEV_SELECTOR).each?
Co-authored-by: Philip Harrison <philip@mailharrison.com>
You're welcome. Yes, it can - I just pushed that change for your review. |
feelepxyz
left a comment
feelepxyz
left a comment
There was a problem hiding this comment.
Looks great, thanks for incorporating the feedback 👍
2 participants
commit-message: prefix-development#4659ItemGroup > DevelopmentDependencygroups in.csprojfilesdevelopmentDependency="true"inpackages.configCondition=property in<Import />, etc.