Skip to content

Fixing issue with nuget devDependency support #4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffwidman merged 5 commits into from
Sep 22, 2022
Merged

Fixing issue with nuget devDependency support #4774

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47a5469
Wiring up dev support and fixing json files
mwaddell Feb 28, 2022
95804db
Merge branch 'main' into nuget_dev_bugfix
mwaddell Feb 28, 2022
20d1655
updating unit tests
mwaddell Feb 28, 2022
333c5e7
Merge branch 'nuget_dev_bugfix' of github.com:pangaeatech/dependabot-…
mwaddell Feb 28, 2022
2b60a71
Merge branch 'dependabot:main' into nuget_dev_bugfix
mwaddell Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion nuget/lib/dependabot/nuget.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,11 @@
register_label_details("nuget", name: ".NET", colour: "7121c6")

require "dependabot/dependency"
Dependabot::Dependency.register_production_check("nuget", ->(_) { true })
Dependabot::Dependency.register_production_check(
"nuget",
lambda do |groups|
return true if groups.empty?

groups.include?("dependencies")
end
)
2 changes: 1 addition & 1 deletion nuget/lib/dependabot/nuget/file_parser/global_json_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def dependency_set
requirements: [{
requirement: version,
file: global_json.name,
groups: [],
groups: ["dependencies"],
source: nil
}]
)
Expand Down
2 changes: 1 addition & 1 deletion nuget/spec/dependabot/nuget/file_parser/global_json_parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
[{
requirement: "1.0.45",
file: "global.json",
groups: [],
groups: ["dependencies"],
source: nil
}]
)
Expand Down
2 changes: 1 addition & 1 deletion nuget/spec/dependabot/nuget/file_parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@
[{
requirement: "1.0.45",
file: "global.json",
groups: [],
groups: ["dependencies"],
source: nil
}]
)
Expand Down
4 changes: 2 additions & 2 deletions nuget/spec/dependabot/nuget/file_updater_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,13 +338,13 @@
requirements: [{
file: "global.json",
requirement: "1.0.52",
groups: [],
groups: ["dependencies"],
source: nil
}],
previous_requirements: [{
file: "global.json",
requirement: "1.0.45",
groups: [],
groups: ["dependencies"],
source: nil
}],
package_manager: "nuget"
Expand Down