Skip to content

Remove unnecessary custom libyaml #13008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbukum1 merged 2 commits into from
Sep 11, 2025
Merged

Remove unnecessary custom libyaml #13008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09385b6
Remove unnecessary custom libyaml
deivid-rodriguez Sep 3, 2025
064b4df
Merge branch 'main' into deivid-rodriguez/revert-libyaml
kbukum1 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions Dockerfile.updater-core
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,6 @@ COPY --chown=dependabot:dependabot LICENSE $DEPENDABOT_HOME
# When bumping Ruby minor, need to also add the previous version to `bundler/helpers/v2/monkey_patches/definition_ruby_version_patch.rb`
COPY --from=docker.io/library/ruby:3.4.5-bookworm --chown=dependabot:dependabot /usr/local /usr/local

# We had to explicitly bump this as the bundled version `0.2.2` in ubuntu 22.04 has a bug.
# Once Ubuntu base image pulls in a new enough yaml version, we may not need to
# explicitly manage this. However, if we do opt to pull it back out, see all changes
# required in https://github.com/dependabot/dependabot-core/pull/7112
ARG LIBYAML_VERSION=0.2.5
RUN curl -sL https://pyyaml.org/download/libyaml/yaml-$LIBYAML_VERSION.tar.gz -o libyaml.tar.gz && \
mkdir -p $DEPENDABOT_HOME/src/libyaml && \
tar -xvf libyaml.tar.gz -C $DEPENDABOT_HOME/src/libyaml && \
rm libyaml.tar.gz

# For users to determine if dependabot is running
ENV DEPENDABOT=true

Expand Down Expand Up @@ -210,12 +200,11 @@ ARG RUBYGEMS_VERSION=3.6.9
ARG GEM_ENABLED=true
RUN if [[ "$GEM_ENABLED" == "true" ]]; then \
gem update --system $RUBYGEMS_VERSION; \
bundle config set --global build.psych --with-libyaml-source-dir=$DEPENDABOT_HOME/src/libyaml/yaml-$LIBYAML_VERSION; \
bundle config set --local path 'vendor'; \
bundle config set --local frozen 'true'; \
bundle config set --local without 'development'; \
bundle install; \
rm -rf ~/.bundle/cache; \
rm -rf ~/.bundle; \
fi


Expand Down
Loading