test(lib): fix SIGSEGV on x86_64-unknown-linux-gnu targets#29794
Merged
nathanwhit merged 1 commit intodenoland:mainfrom Jun 18, 2025
Merged
test(lib): fix SIGSEGV on x86_64-unknown-linux-gnu targets#29794nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit merged 1 commit intodenoland:mainfrom
Conversation
|
|
13 tasks
limwa
force-pushed
the
fix/sigsegv-unit-tests
branch
from
d84dca5 to
1a32b04
Compare
limwa
force-pushed
the
fix/sigsegv-unit-tests
branch
from
1a32b04 to
b99a81f
Compare
limwa
changed the title
13 tasks
dsherret
reviewed
Jun 18, 2025
| chrono = { workspace = true, features = ["now"] } | ||
| deno_bench_util.workspace = true | ||
| deno_cache_dir.workspace = true | ||
| deno_core = { workspace = true, features = ["unsafe_use_unprotected_platform"] } |
Member
There was a problem hiding this comment.
This dependency isn't used by the tests crate. I'll do a follow-up pr to fix this.
Contributor
Author
There was a problem hiding this comment.
Should it have gone into the dev_dependencies in cli/Cargo.toml?
Member
There was a problem hiding this comment.
Yeah, that's what I did in #29806 which should cause the other crates to be built with that feature enabled without adding a dependency to deno_core for the tests crate.
CyanChanges
pushed a commit
to CyanChanges/deno
that referenced
this pull request
Jun 23, 2025
…29794) Fixes denoland#29793. This PR reapplies denoland#22152 (see issue for further details). Changes `deno_core` in tests to be built with the `unsafe_use_unprotected_platform` feature. The issue is caused by two or more threads (in Deno's test suite, tests are spread out across worker threads) in the same process accessing v8's isolates (see denoland/deno_core#471 for further details).
CyanChanges
pushed a commit
to CyanChanges/deno
that referenced
this pull request
Jun 23, 2025
…enoland#29806) The tests crate doesn't have a dependency on deno_core. Amendment to denoland#29794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29793.
This PR reapplies #22152 (see issue for further details).
Changes
deno_corein tests to be built with theunsafe_use_unprotected_platformfeature.The issue is caused by two or more threads (in Deno's test suite, tests are spread out across worker threads) in the same process accessing v8's isolates (see denoland/deno_core#471 for further details).