deno: 2.3.5 -> 2.3.6, fix tests by ofalvai · Pull Request #416177 · NixOS/nixpkgs

ofalvai · 2025-06-12T15:41:26Z

https://github.com/denoland/deno/releases/tag/v2.3.6

Running the tests have become more complicated since denoland/deno#29470 because a prebuilt esbuild binary is now required for around half the tests.

Also addresses the crashes reported at #417331. I hope it's okay not to split the changes into multiple commits, my thinking was that the version upgrade is not buildable on all platforms without the test-related fixes.

Things done

Add a 👍 reaction to pull requests you find important.

ofalvai · 2025-06-13T06:26:15Z

A huge number of tests are failing on Linux (not on Darwin). I'm investigating

ofalvai · 2025-06-17T07:03:52Z

I figured out the test crashes, the root cause is denoland/deno#29470. A prebuilt esbuild binary is now required for around half the tests, so I set that up in preCheck.

Also addressed the x86_64-linux crashes reported at #417331.

@06kellyjac @limwa I would appreciate your review and tests

ofalvai · 2025-06-17T07:53:06Z

Tested on all 4 platforms and it built fine.

b-rodrigues · 2025-06-17T08:46:12Z

Tested on x86-linux by building quarto (which depends on deno), and this sloves it!

06kellyjac · 2025-06-17T10:21:47Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416177

`x86_64-linux`

❌ 12 packages failed to build:

deno
denort
era
gleam
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
silverbullet
windmill

06kellyjac · 2025-06-17T10:44:15Z

for the failure logs:

nix log /nix/store/b7sv6sfgj7y2w7jwlynp8aydv8ys5067-deno-2.3.6.drv:

[serve_test 011.58] Listening on http://0.0.0.0:4511/ (http://localhost:4511/)
[serve_test 011.59] Deno.HttpServer is not thenable ... ok (2ms)
[serve_test 011.61] httpServerUnixDomainSocket ... ok (17ms)
[serve_test 011.62] httpServerVsockSocket ... FAILED (10ms)
[serve_test 011.64] handleServeCallbackReturn ... ok (25ms)
[serve_test 011.66] Exception in onError while handling exception TypeError: Return value from onError handler must be a response or a promise resolving to a response
[serve_test 011.66]     at mapped (ext:deno_http/00_serve.ts:414:17)
[serve_test 011.66]     at eventLoopTick (ext:core/01_core.js:178:7)
[serve_test 011.66] handleServeErrorCallbackReturn ... ok (13ms)
[serve_test 011.66] gzipFlushResponseStream ...
[serve_test 011.66] ------- output -------
[serve_test 011.66] Starting server 4511
[serve_test 012.73] ----- output end -----
[serve_test 012.73] gzipFlushResponseStream ... ok (1s)
[serve_test 012.73] HTTP Server test (error on non-unix platform) ... ignored (0ms)
[serve_test 012.73] onListen callback gets 0.0.0.0 hostname as is ... ok (0ms)
[serve_test 015.73] AbortSignal aborted when request is cancelled ... ok (3s)
[serve_test 015.84] AbortSignal event aborted when request is cancelled ... ok (102ms)
[serve_test 015.88] httpServerWebSocketInspectRequest ... ok (47ms)
[serve_test 016.09] req.body.getReader().read() throws the error with reasonable error message ... ok (207ms)
[serve_test 016.10] httpServerVsockWebSocketUpgrade ... FAILED (6ms)
[serve_test 016.11]
[serve_test 016.11]  ERRORS
[serve_test 016.11]
[serve_test 016.11] httpServerVsockSocket => ./tests/unit/serve_test.ts:4061:6
[serve_test 016.11] error: Error: Address family not supported by protocol (os error 97)
[serve_test 016.11]     await using server = Deno.serve(
[serve_test 016.11]                               ^
[serve_test 016.11]     at listen (ext:deno_net/01_net.js:603:43)
[serve_test 016.11]     at serveInner (ext:deno_http/00_serve.ts:642:22)
[serve_test 016.11]     at Object.serve (ext:deno_http/00_serve.ts:615:10)
[serve_test 016.11]     at httpServerVsockSocket (file:///build/source/tests/unit/serve_test.ts:4069:31)
[serve_test 016.11]
[serve_test 016.11] httpServerVsockWebSocketUpgrade => ./tests/unit/serve_test.ts:4432:6
[serve_test 016.11] error: Error: Address family not supported by protocol (os error 97)
[serve_test 016.11]     await using server = Deno.serve(
[serve_test 016.11]                               ^
[serve_test 016.11]     at listen (ext:deno_net/01_net.js:603:43)
[serve_test 016.11]     at serveInner (ext:deno_http/00_serve.ts:642:22)
[serve_test 016.11]     at Object.serve (ext:deno_http/00_serve.ts:615:10)
[serve_test 016.11]     at httpServerVsockWebSocketUpgrade (file:///build/source/tests/unit/serve_test.ts:4442:31)
[serve_test 016.11]
[serve_test 016.11]  FAILURES
[serve_test 016.11]
[serve_test 016.11] httpServerVsockSocket => ./tests/unit/serve_test.ts:4061:6
[serve_test 016.11] httpServerVsockWebSocketUpgrade => ./tests/unit/serve_test.ts:4432:6
[serve_test 016.11]
[serve_test 016.11] FAILED | 158 passed | 2 failed | 2 ignored (12s)
[serve_test 016.11]
[serve_test 016.12] error: Test failed

thread 'js_unit_tests::serve_test' panicked at tests/integration/js_unit_tests.rs:230:3:
assertion `left == right` failed: Deno should have exited cleanly
  left: Some(0)
 right: Some(1)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    js_unit_tests::serve_test

test result: FAILED. 813 passed; 1 failed; 10 ignored; 0 measured; 14 filtered out; finished in 50.22s

error: test failed, to rerun pass `-p cli_tests --test integration_tests`

To be clear these builds ran on my arch machine but it has sandbox enabled & build agents.

Running cat /proc/net/vsock on that machine (and also on my nixos box) gets nothing.

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/networking/vwifi.nix#L159-L161

Probably easiest to skip all vsock related tests.

nix log /nix/store/4r5ycdi4j0fh5zl5zah0x1lvs4r20hkg-denort-2.3.6.drv:

   Compiling deno_runtime v0.215.0 (/build/source/runtime)
warning: unused variable: `metrics_enabled`
  --> runtime/tokio_util.rs:62:3
   |
62 |   metrics_enabled: bool,
   |   ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metrics_enabled`
   |
   = note: `#[warn(unused_variables)]` on by default

warning: `deno_runtime` (lib) generated 1 warning
   Compiling deno_snapshots v0.22.0 (/build/source/cli/snapshot)
   Compiling denort v2.3.6 (/build/source/cli/rt)
    Finished `release` profile [optimized + debuginfo] target(s) in 10m 11s
/build/source
Executing cargoInstallPostBuildHook
Finished cargoInstallPostBuildHook
Finished cargoBuildHook
buildPhase completed in 10 minutes 13 seconds
Running phase: checkPhase
Executing cargoCheckHook
/build/source/cli/rt /build/source
cargoCheckHook flags: -j 32 --profile release --target x86_64-unknown-linux-gnu --offline --test integration_tests -- --skip=check::ts_no_recheck_on_redirect --skip=js_unit_tests::quic_test --skip=js_unit_tests::net_test --skip=node_unit_tests>
error: no test target named `integration_tests`.
Available test targets:
    integration

I may be being stupid here but I can't for the life of me find where the "denort" derivation comes from.....
If there's another package doing an override to get a denort build we should probably not delete it in the main deno build, maybe put it into a separate output.

GaetanLepage · 2025-06-17T11:32:59Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416177
Commit: 876eab68fc5c052477bc9063df223f6344750c94

`x86_64-linux`

❌ 1 package failed to build:

denort

✅ 11 packages built:

deno
era
gleam
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
silverbullet
windmill

`aarch64-linux`

❌ 1 package failed to build:

denort

✅ 11 packages built:

deno
era
gleam
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
silverbullet
windmill

`x86_64-darwin`

❌ 2 packages failed to build:

denort
gleam

✅ 7 packages built:

deno
era
quarto
quartoMinimal
rstudio
rstudioWrapper
silverbullet

`aarch64-darwin`

❌ 1 package failed to build:

denort

✅ 8 packages built:

deno
era
gleam
quarto
quartoMinimal
rstudio
rstudioWrapper
silverbullet

Error logs: `x86_64-linux`

denort

   Compiling env_logger v0.11.6
   Compiling deno_npm_installer v0.2.0 (/build/source/resolvers/npm_installer)
   Compiling libsui v0.10.0
warning: `deno_runtime` (lib) generated 1 warning
   Compiling deno_snapshots v0.22.0 (/build/source/cli/snapshot)
   Compiling denort v2.3.6 (/build/source/cli/rt)
    Finished `release` profile [optimized + debuginfo] target(s) in 11m 22s
/build/source
Executing cargoInstallPostBuildHook
Finished cargoInstallPostBuildHook
Finished cargoBuildHook
buildPhase completed in 11 minutes 23 seconds
Running phase: checkPhase
Executing cargoCheckHook
/build/source/cli/rt /build/source
cargoCheckHook flags: -j 12 --profile release --target x86_64-unknown-linux-gnu --offline --test integration_tests -- --skip=check::ts_no_recheck_on_redirect --skip=js_unit_tests::quic_test --skip=js_unit_tests::net_test --skip=node_unit_tests::http_test --skip=node_unit_tests::http2_test --skip=node_unit_tests::net_test --skip=node_unit_tests::tls_test --skip=npm::lock_file_lock_write --skip=js_unit_tests::webgpu_test --skip=js_unit_tests::jupyter_test --skip=specs::permission::proc_self_fd --skip=init::init_subcommand_serve --skip=serve::deno_serve_parallel --skip=js_unit_tests::stat_test --skip=repl::pty_complete_imports_no_panic_empty_specifier
error: no test target named `integration_tests`.
Available test targets:
    integration

Error logs: `aarch64-linux`

denort

   |
62 |   metrics_enabled: bool,
   |   ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metrics_enabled`
   |
   = note: `#[warn(unused_variables)]` on by default
warning: deno_runtime (lib) generated 1 warning

Compiling deno_snapshots v0.22.0 (/build/source/cli/snapshot)

Compiling denort v2.3.6 (/build/source/cli/rt)

Finished release profile [optimized + debuginfo] target(s) in 12m 03s

/build/source

Executing cargoInstallPostBuildHook

Finished cargoInstallPostBuildHook

Finished cargoBuildHook

buildPhase completed in 12 minutes 3 seconds

Running phase: checkPhase

Executing cargoCheckHook

/build/source/cli/rt /build/source

cargoCheckHook flags: -j 40 --profile release --target aarch64-unknown-linux-gnu --offline --test integration_tests --lib -- --skip=check::ts_no_recheck_on_redirect --skip=js_unit_tests::quic_test --skip=js_unit_tests::net_test --skip=node_unit_tests::http_test --skip=node_unit_tests::http2_test --skip=node_unit_tests::net_test --skip=node_unit_tests::tls_test --skip=npm::lock_file_lock_write --skip=js_unit_tests::webgpu_test --skip=js_unit_tests::jupyter_test --skip=specs::permission::proc_self_fd --skip=init::init_subcommand_serve --skip=serve::deno_serve_parallel --skip=js_unit_tests::stat_test --skip=repl::pty_complete_imports_no_panic_empty_specifier

error: no library targets found in package denort

Error logs: `x86_64-darwin`

denort

   Compiling deno_snapshots v0.22.0 (/private/tmp/nix-build-denort-2.3.6.drv-1/source/cli/snapshot)
   Compiling deno_npm_cache v0.26.0 (/private/tmp/nix-build-denort-2.3.6.drv-1/source/resolvers/npm_cache)
   Compiling env_filter v0.1.3
   Compiling humantime v2.1.0
   Compiling deno_lib v0.25.0 (/private/tmp/nix-build-denort-2.3.6.drv-1/source/cli/lib)
   Compiling env_logger v0.11.6
   Compiling deno_npm_installer v0.2.0 (/private/tmp/nix-build-denort-2.3.6.drv-1/source/resolvers/npm_installer)
   Compiling denort v2.3.6 (/private/tmp/nix-build-denort-2.3.6.drv-1/source/cli/rt)
   Compiling libsui v0.10.0
    Finished `release` profile [optimized + debuginfo] target(s) in 30m 42s
/private/tmp/nix-build-denort-2.3.6.drv-1/source
Executing cargoInstallPostBuildHook
Finished cargoInstallPostBuildHook
Finished cargoBuildHook
buildPhase completed in 34 minutes 21 seconds
Running phase: checkPhase
Executing cargoCheckHook
/private/tmp/nix-build-denort-2.3.6.drv-1/source/cli/rt /private/tmp/nix-build-denort-2.3.6.drv-1/source
cargoCheckHook flags: -j 5 --profile release --target x86_64-apple-darwin --offline --test integration_tests --lib -- --skip=check::ts_no_recheck_on_redirect --skip=js_unit_tests::quic_test --skip=js_unit_tests::net_test --skip=node_unit_tests::http_test --skip=node_unit_tests::http2_test --skip=node_unit_tests::net_test --skip=node_unit_tests::tls_test --skip=npm::lock_file_lock_write --skip=js_unit_tests::webgpu_test --skip=js_unit_tests::jupyter_test --skip=specs::permission::proc_self_fd --skip=init::init_subcommand_serve --skip=serve::deno_serve_parallel --skip=js_unit_tests::stat_test --skip=repl::pty_complete_imports_no_panic_empty_specifier --skip=shared_library_tests::macos_shared_libraries --skip=watcher --skip=node_unit_tests::_fs_watch_test --skip=js_unit_tests::fs_events_test
error: no library targets found in package `denort`

gleam

thread 'tests::echo::echo_tuple' panicked at /private/tmp/nix-build-gleam-1.11.1.drv-0/gleam-1.11.1-vendor/insta-1.41.1/src/runtime.rs:721:13: snapshot assertion for 'echo_tuple' failed in line 186. Result does not match previous snapshot in allow-duplicates block.

failures:
tests::echo::echo_bitarray
tests::echo::echo_bool
tests::echo::echo_custom_type
tests::echo::echo_float
tests::echo::echo_function
tests::echo::echo_importing_module_named_inspect
tests::echo::echo_int
tests::echo::echo_list
tests::echo::echo_nil
tests::echo::echo_string
tests::echo::echo_tuple

test result: FAILED. 1 passed; 11 failed; 0 ignored; 0 measured; 1 filtered out; finished in 15.13s

error: test failed, to rerun pass -p test-output --lib

Error logs: `aarch64-darwin`

denort

   Compiling deno_snapshots v0.22.0 (/private/tmp/nix-build-denort-2.3.6.drv-0/source/cli/snapshot)
   Compiling deno_npm_cache v0.26.0 (/private/tmp/nix-build-denort-2.3.6.drv-0/source/resolvers/npm_cache)
   Compiling env_filter v0.1.3
   Compiling deno_lib v0.25.0 (/private/tmp/nix-build-denort-2.3.6.drv-0/source/cli/lib)
   Compiling humantime v2.1.0
   Compiling env_logger v0.11.6
   Compiling deno_npm_installer v0.2.0 (/private/tmp/nix-build-denort-2.3.6.drv-0/source/resolvers/npm_installer)
   Compiling denort v2.3.6 (/private/tmp/nix-build-denort-2.3.6.drv-0/source/cli/rt)
   Compiling libsui v0.10.0
    Finished `release` profile [optimized + debuginfo] target(s) in 26m 29s
/private/tmp/nix-build-denort-2.3.6.drv-0/source
Executing cargoInstallPostBuildHook
Finished cargoInstallPostBuildHook
Finished cargoBuildHook
buildPhase completed in 29 minutes 35 seconds
Running phase: checkPhase
Executing cargoCheckHook
/private/tmp/nix-build-denort-2.3.6.drv-0/source/cli/rt /private/tmp/nix-build-denort-2.3.6.drv-0/source
cargoCheckHook flags: -j 5 --profile release --target aarch64-apple-darwin --offline --test integration_tests --lib -- --skip=check::ts_no_recheck_on_redirect --skip=js_unit_tests::quic_test --skip=js_unit_tests::net_test --skip=node_unit_tests::http_test --skip=node_unit_tests::http2_test --skip=node_unit_tests::net_test --skip=node_unit_tests::tls_test --skip=npm::lock_file_lock_write --skip=js_unit_tests::webgpu_test --skip=js_unit_tests::jupyter_test --skip=specs::permission::proc_self_fd --skip=init::init_subcommand_serve --skip=serve::deno_serve_parallel --skip=js_unit_tests::stat_test --skip=repl::pty_complete_imports_no_panic_empty_specifier --skip=shared_library_tests::macos_shared_libraries --skip=watcher --skip=node_unit_tests::_fs_watch_test --skip=js_unit_tests::fs_events_test
error: no library targets found in package `denort`

b-rodrigues · 2025-06-17T11:42:31Z

Seems like some tests are still flaky, maybe they should be disabled altogether, like before 1161ba5 ?

GaetanLepage · 2025-06-17T11:47:41Z

Seems like some tests are still flaky, maybe they should be disabled altogether, like before 1161ba5 ?

Is this already happening on master or is it a "regression" from this update?

Cronos6096 · 2025-06-17T11:50:53Z

Looks like a regression

b-rodrigues · 2025-06-17T11:54:24Z

Looks like a regression

I’ve had issues on master as well (it’s the reason I’m here), see: https://hydra.nixos.org/build/300144659#tabs-summary

GaetanLepage · 2025-06-17T11:57:57Z

Let's just skip the flaky tests if flakiness is indeed the culprit.

limwa · 2025-06-17T12:15:22Z

~~I've narrowed down the tests that crash with SIGSEGV on x86_64-linux (on my machine, at least) to ops::tests::tcp_set_keepalive and ops::ipc::impl_::tests::ipc_serialization.~~ My PC ran the check phase continuously with the --lib flag and those two tests skipped for ~10 hours and it didn't crash a single time.

limwa · 2025-06-17T12:22:48Z

One downside of reenabing unit tests on x86_64-linux is that in the next version another test could crash with SIGSEGV and the list of skipped tests would need to be updated. Furthermore, it could happen that noone in review experiences a crash and then Hydra crashes with SIGSEGV (due to the randomness of the crashes).

For safety, I think the unit tests can remain disabled entirely in x86_64-linux, but it would be interesting to find out what's causing these segfaults and maybe fix them upstream or in the derivations and, eventually, re-enable unit tests on x86_64-linux.

06kellyjac · 2025-06-17T13:35:42Z

Found the denort derivation, needed to pull latest

#407434

ofalvai · 2025-06-18T16:36:36Z

Yes, rebased the PR and I can reproduce on both aarch64 and x86_64 Linux :/ I'll try a git bisect

ofalvai · 2025-06-18T17:19:18Z

git bisect --first-parent stopped at #412425 🙃

limwa · 2025-06-18T17:20:20Z

That'll be wonderful to debug 😄

pkgs/by-name/de/deno/package.nix

ofalvai · 2025-06-18T19:00:11Z

I'm pretty sure we hit this bug in the recently upgraded Rust + LLVM combination: rust-lang/rust#141737

The good news is disabling LTO fixes the build.

limwa · 2025-06-18T19:25:01Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416177 --package deno
Commit: 6e0a17306b666ed57a79ac9578c2d0e3cb61f3eb

`x86_64-linux`

✅ 1 package built:

deno

limwa · 2025-06-18T19:27:27Z

Great work!

I'd suggest using the new Cargo.toml patch and then checking if there are any other tests to skip. Other than that, at least in x86_64-linux, everything is looking great!

limwa · 2025-06-18T19:28:05Z

Oh, and #417619 can be closed, I think

ofalvai · 2025-06-18T19:37:50Z

Yup, just wanted to finish testing on aarch64-linux before pushing my changes. Patch is now up-to-date, LTO is disabled for Linux, and tests seem to pass (but I'll run some repeated tests overnight just in case)

GaetanLepage · 2025-06-19T05:39:49Z

Can you please format the code with nixfmt?

ofalvai · 2025-06-19T05:43:55Z

Done. I ran a nixpkgs-review with the 2 Darwin platforms and noticed that x86_64-darwin also crashes at linking (with a similar error). So I'm disabling LTO on x86_64-darwin and run a nixpkgs-review soon

ofalvai · 2025-06-19T06:40:36Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416177 --package deno
Commit: abc9b18038ae082c05ad2c0cbab1506fa2ec4d87

`x86_64-darwin`

✅ 1 package built:

deno

`aarch64-darwin`

✅ 1 package built:

deno

GaetanLepage · 2025-06-19T09:17:09Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416177
Commit: abc9b18038ae082c05ad2c0cbab1506fa2ec4d87

`x86_64-linux`

✅ 11 packages built:

deno
era
gleam
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
silverbullet
windmill

`aarch64-linux`

✅ 11 packages built:

deno
era
gleam
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
silverbullet
windmill

`x86_64-darwin`

❌ 1 package failed to build:

gleam

✅ 7 packages built:

deno
era
quarto
quartoMinimal
rstudio
rstudioWrapper
silverbullet

`aarch64-darwin`

✅ 8 packages built:

deno
era
gleam
quarto
quartoMinimal
rstudio
rstudioWrapper
silverbullet

Error logs: `x86_64-darwin`

gleam

thread 'tests::echo::echo_string' panicked at /private/tmp/nix-build-gleam-1.11.1.drv-0/gleam-1.11.1-vendor/insta-1.41.1/src/runtime.rs:721:13: snapshot assertion for 'echo_string' failed in line 181. Result does not match previous snapshot in allow-duplicates block.

failures:
tests::echo::echo_bitarray
tests::echo::echo_bool
tests::echo::echo_custom_type
tests::echo::echo_float
tests::echo::echo_function
tests::echo::echo_importing_module_named_inspect
tests::echo::echo_int
tests::echo::echo_list
tests::echo::echo_nil
tests::echo::echo_string
tests::echo::echo_tuple

test result: FAILED. 1 passed; 11 failed; 0 ignored; 0 measured; 1 filtered out; finished in 25.94s

error: test failed, to rerun pass -p test-output --lib

GaetanLepage

Thanks!

As deno is not building on x86_64-darwin on master, let's merge this PR and deal with gleam afterwards.

Nit (for next time): Try to keep comments out of Nix strings. It allows changing them without leading to useless rebuilds.

PR NixOS/nixpkgs#416177 was merged.

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 12, 2025

ofalvai force-pushed the push-zzolnwsuprrl branch from f86a597 to 4832a89 Compare June 12, 2025 15:43

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 12, 2025

nix-owners bot requested a review from 06kellyjac June 12, 2025 15:48

ofalvai force-pushed the push-zzolnwsuprrl branch from 4832a89 to 663c2b6 Compare June 12, 2025 16:45

ofalvai force-pushed the push-zzolnwsuprrl branch 3 times, most recently from 6f18565 to faa9fe3 Compare June 14, 2025 09:07

ofalvai mentioned this pull request Jun 17, 2025

Build failure: deno #417331

Closed

3 tasks

ofalvai force-pushed the push-zzolnwsuprrl branch from faa9fe3 to 876eab6 Compare June 17, 2025 06:58

ofalvai changed the title ~~deno: 2.3.5 -> 2.3.6~~ deno: 2.3.5 -> 2.3.6, fix tests Jun 17, 2025

06kellyjac mentioned this pull request Jun 17, 2025

Feat/build deno package #407434

Merged

13 tasks

ofalvai force-pushed the push-zzolnwsuprrl branch from cc59cdd to 9612e43 Compare June 18, 2025 15:52

limwa reviewed Jun 18, 2025

View reviewed changes

pkgs/by-name/de/deno/package.nix Outdated

Comment on lines 46 to 51

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

ofalvai added 2 commits June 18, 2025 21:11

deno: 2.3.5 -> 2.3.6

c81cc83

deno: skip more flaky or unreliable tests

d88d273

ofalvai force-pushed the push-zzolnwsuprrl branch from 6e0a173 to 4c68c44 Compare June 18, 2025 19:35

ofalvai force-pushed the push-zzolnwsuprrl branch from 4c68c44 to c0db458 Compare June 19, 2025 05:36

deno: disable LTO on Linux and x86_64-darwin

abc9b18

ofalvai force-pushed the push-zzolnwsuprrl branch from c0db458 to abc9b18 Compare June 19, 2025 05:42

GaetanLepage approved these changes Jun 19, 2025

View reviewed changes

GaetanLepage requested a review from kirillrdy June 19, 2025 09:53

github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 19, 2025

GaetanLepage requested a review from SuperSandro2000 June 19, 2025 12:38

SuperSandro2000 approved these changes Jun 19, 2025

View reviewed changes

SuperSandro2000 merged commit dee0fb2 into NixOS:master Jun 19, 2025
24 of 26 checks passed

limwa added a commit to limwa/nix-registry that referenced this pull request Jun 19, 2025

chore(template-deno): use master branch

0a00ecc

PR NixOS/nixpkgs#416177 was merged.

Just-Helpful mentioned this pull request Jun 19, 2025

Deno-2.3.5 failing to build NotAShelf/nvf#952

Closed

1 task

b-rodrigues mentioned this pull request Jun 21, 2025

R updates #416842

Merged

13 tasks

kachick mentioned this pull request Aug 6, 2025

esbuild: 0.27.2 -> 0.27.3 #423375

Draft

Uh oh!

Conversation

ofalvai commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

ofalvai commented Jun 13, 2025

Uh oh!

ofalvai commented Jun 17, 2025

Uh oh!

ofalvai commented Jun 17, 2025

Uh oh!

b-rodrigues commented Jun 17, 2025

Uh oh!

06kellyjac commented Jun 17, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

06kellyjac commented Jun 17, 2025

Uh oh!

GaetanLepage commented Jun 17, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

b-rodrigues commented Jun 17, 2025

Uh oh!

GaetanLepage commented Jun 17, 2025

Uh oh!

Cronos6096 commented Jun 17, 2025

Uh oh!

b-rodrigues commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaetanLepage commented Jun 17, 2025

Uh oh!

limwa commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

limwa commented Jun 17, 2025

Uh oh!

06kellyjac commented Jun 17, 2025

Uh oh!

ofalvai commented Jun 18, 2025

Uh oh!

ofalvai commented Jun 18, 2025

Uh oh!

limwa commented Jun 18, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

ofalvai commented Jun 18, 2025

Uh oh!

limwa commented Jun 18, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

limwa commented Jun 18, 2025

Uh oh!

limwa commented Jun 18, 2025

Uh oh!

ofalvai commented Jun 18, 2025

Uh oh!

GaetanLepage commented Jun 19, 2025

Uh oh!

ofalvai commented Jun 19, 2025

Uh oh!

ofalvai commented Jun 19, 2025

nixpkgs-review result

x86_64-darwin

aarch64-darwin

Uh oh!

GaetanLepage commented Jun 19, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

ofalvai commented Jun 12, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

b-rodrigues commented Jun 17, 2025 •

edited

Loading

limwa commented Jun 17, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`